This repository was archived by the owner on Mar 2, 2026. It is now read-only.
feat(datastore): add missing method for system test with emulator#19
Merged
crwilcox merged 3 commits intogoogleapis:masterfrom Apr 7, 2020
Merged
feat(datastore): add missing method for system test with emulator#19crwilcox merged 3 commits intogoogleapis:masterfrom
crwilcox merged 3 commits intogoogleapis:masterfrom
Conversation
googlebot
added
the
cla: yes
Contributor
|
Where is the code that uses this? |
Contributor
Author
|
Here method has called but implementation was not there. python-datastore/tests/system/test_system.py Lines 252 to 256 in 96fd5b8 |
Contributor
|
Have you validated this locally, or would this run in ci? I ask as delete_multi can only take so many keys at once. |
Contributor
Author
|
I have validate locally, it works fine and delete all the keys. |
crwilcox
approved these changes
Apr 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards bigtable-5