Skip to content

feat: remove six dependency #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
crwilcox merged 1 commit into from
Nov 25, 2020
Merged

feat: remove six dependency #120

crwilcox merged 1 commit into from
Nov 25, 2020

Conversation

@HemangChothani
Copy link
Contributor

@HemangChothani HemangChothani commented Nov 25, 2020

Fixes #119

@HemangChothani HemangChothani requested a review from a team November 25, 2020 07:53
@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/python-datastore API. label Nov 25, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 25, 2020
@crwilcox crwilcox merged commit b1715e5 into googleapis:master Nov 25, 2020
@tseaver
Copy link
Contributor

tseaver commented Dec 2, 2020

I would argue that dropping a dependency is semver patch, versus semver minor: this is actually just housekeeping after the semver major drop of Python 2.7.

@tseaver tseaver mentioned this pull request Dec 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@crwilcox crwilcox crwilcox approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: datastore Issues related to the googleapis/python-datastore API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove dependency on six

3 participants

@HemangChothani @tseaver @crwilcox