Skip to content

feat: Backup Level IAM #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kolea2 merged 1 commit into from
Nov 12, 2020
Merged

feat: Backup Level IAM #160

kolea2 merged 1 commit into from
Nov 12, 2020

Conversation

@mf2199
Copy link
Contributor

@mf2199 mf2199 commented Oct 31, 2020

Implementing Backup Level IAM methods.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 31, 2020
@mf2199 mf2199 added api: bigtable Issues related to the googleapis/python-bigtable API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Oct 31, 2020
@mf2199 mf2199 requested a review from kolea2 October 31, 2020 19:46
kolea2
kolea2 reviewed Nov 10, 2020
View reviewed changes
Copy link
Collaborator

@kolea2 kolea2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. @crwilcox mind taking a quick look?

@mf2199 mf2199 marked this pull request as ready for review November 10, 2020 20:53
@mf2199 mf2199 requested a review from a team as a code owner November 10, 2020 20:53
tseaver
tseaver approved these changes Nov 11, 2020
View reviewed changes
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kolea2 kolea2 merged commit 44932cb into googleapis:master Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kolea2 kolea2 kolea2 approved these changes

+1 more reviewer

@tseaver tseaver tseaver approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtable Issues related to the googleapis/python-bigtable API. cla: yes This human has signed the Contributor License Agreement. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mf2199 @tseaver @kolea2