This repository was archived by the owner on Nov 29, 2023. It is now read-only.
fix: add dataset id in function call#44
Merged
plamut merged 1 commit intoSep 11, 2020
Merged
Conversation
google-cla
Bot
added
the
cla: yes
plamut
reviewed
Sep 11, 2020
plamut
left a comment
plamut
left a comment
Contributor
There was a problem hiding this comment.
Was there a test that failed because of that? If not, I suggest adding one that covers this code path to protect us from future regressions.
The fix itself looks good.
Contributor
Author
|
@plamut We are using python-bigquery-datatransfer/samples/snippets/quickstart.py Lines 40 to 41 in afe5219 not sure how to cover this kind of call and also not found for the quickstart as well. |
Contributor
|
@HemangChothani OK, fair enough, let's merge it then. 👍 |
plamut
approved these changes
Sep 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #43