Skip to content

fix: Important the correct constants and use v1 for tensorboard experiments #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mkovalski merged 4 commits into from
Dec 14, 2021
Merged

fix: Important the correct constants and use v1 for tensorboard experiments #905

mkovalski merged 4 commits into from
Dec 14, 2021

Conversation

@mkovalski
Copy link
Contributor

@mkovalski mkovalski commented Dec 13, 2021 •
edited
Loading

  • Previous tensorboard_api used aiplatform.constants, should use aiplatform.constants.base to override.
  • Use v1 version of the tensorboard experiment for uploading profiling files.

Fixes #906

@mkovalski mkovalski requested a review from sasha-gitg December 13, 2021 16:30
@mkovalski mkovalski marked this pull request as ready for review December 13, 2021 16:30
@mkovalski mkovalski requested a review from yfang1 December 13, 2021 16:35
@mkovalski mkovalski merged commit 48c2bf1 into googleapis:main Dec 14, 2021
morgandu pushed a commit to morgandu/python-aiplatform that referenced this pull request Dec 14, 2021
@mkovalski @morgandu
fix: Important the correct constants and use v1 for tensorboard exper…
b8a21c9 
…iments (googleapis#905)

* fix: Important the correct constants and use v1 for tensorboard experiments

* fix: fixing linting errors
morgandu pushed a commit to morgandu/python-aiplatform that referenced this pull request Dec 14, 2021
@mkovalski @morgandu
fix: Important the correct constants and use v1 for tensorboard exper…
b37d5c2 
…iments (googleapis#905)

* fix: Important the correct constants and use v1 for tensorboard experiments

* fix: fixing linting errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sasha-gitg sasha-gitg sasha-gitg approved these changes

+1 more reviewer

@yfang1 yfang1 yfang1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Profile uploader fails for tensorboard v1beta

3 participants

@mkovalski @sasha-gitg @yfang1