release-26.1: roachtest: set pgwire max repeated error to 256 in c2c mixed version #160283
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On pre 26.1 versions by default, pgwire retries opening a connection tens of thousands of times, which could cause overload in the c2c/mixedversion roachtest. Now that `sql.pgwire.max_repeated_error_count` has been backported to 25.2+, we can deflake the roachtest by setting the max error count to 256. Informs cockroachdb#150401 Release note: none
msbutler
force-pushed
the
blathers/backport-release-26.1-160273
branch
from
29d1b2d to
86506a7
Compare
blathers-crl
bot
added
blathers-backport
|
Thanks for opening a backport. Before merging, please confirm that the change does not break backwards compatibility and otherwise complies with the backport policy. Include a brief release justification in the PR description explaining why the backport is appropriate. All backports must be reviewed by the TL for the owning area. While the stricter LTS policy does not yet apply, please exercise judgment and consider gating non-critical changes behind a disabled-by-default feature flag when appropriate. |
blathers-crl
bot
added
backport
Member
|
This change is |
blathers-crl
bot
added
the
backport-test-only
![blathers-crl[bot]](https://avatars.githubusercontent.com/in/59700?s=60&v=4){kind=small}
github-actions
bot
merged commit 70a14c3
into
cockroachdb:release-26.1
15 of 16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #160273 on behalf of @msbutler.
On pre 26.1 versions by default, pgwire retries opening a connection tens of thousands of times, which could cause overload in the c2c/mixedversion roachtest. Now that
sql.pgwire.max_repeated_error_counthas been backported to 25.2+, we can deflake the roachtest by setting the max error count to 256.Informs #150401
Release note: none
Release justification: