backup: support SHOW BACKUPS with backup ids #160137
Open
+789
−91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kev-cao
requested review from
asg0451,
msbutler,
nameisbhaskar,
shailendra-patel and
xinhaoz
and removed request for
a team
|
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
kev-cao
requested review from
a team,
DrewKimball,
andyyang890 and
mw5h
and removed request for
a team,
DrewKimball,
andyyang890,
asg0451,
mw5h,
nameisbhaskar,
shailendra-patel and
xinhaoz
Member
|
This change is |
Contributor
Author
|
Sample output: 
|
kev-cao
force-pushed
the
backup/show-backups-with-index
branch
2 times, most recently
from
42e67c6 to
5cce80a
Compare
Potential Bug(s) DetectedThe three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation. Next Steps: Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary. After you review the findings, please tag the issue as follows:
|
github-actions
bot
added
the
o-AI-Review-Potential-Issue-Detected
kev-cao
force-pushed
the
backup/show-backups-with-index
branch
from
5cce80a to
6a89de0
Compare
kev-cao
added
O-AI-Review-Not-Helpful
kev-cao
force-pushed
the
backup/show-backups-with-index
branch
2 times, most recently
from
3ad3a7b to
19c402c
Compare
This commit adds the `ListRestorableBackup` helper, which reads through the index and returns all restorable times along with their associated backup IDs. Epic: CRDB-57536 Informs: cockroachdb#159647 Release note: None
kev-cao
force-pushed
the
backup/show-backups-with-index
branch
2 times, most recently
from
6927fd6 to
72e268c
Compare
This commit teaches SHOW BACKUPS to display the new UX with backup IDs, along with BEFORE/AFTER filtering. Epic: CRDB-57536 Resolves: cockroachdb#159647 Release note: None
kev-cao
force-pushed
the
backup/show-backups-with-index
branch
from
72e268c to
243a136
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit teaches SHOW BACKUPS to display the new UX with backup IDs, along with BEFORE/AFTER filtering.
Epic: CRDB-57536
Resolves: #159647
Release note: None