Skip to content

Conversation

@blueskyonmars
Copy link
Contributor

This is for code review right now. It adds selection of multiple expressions to extract-function.

TODO:

  • rename extract-function-2 to something else OR replace existing
    extract-function? They behave almost exactly the same. The big issue is that
    this requires different parameters (two new ones - the beginning and end of
    the selection)

  • change Calva to handle selection formats from clojure-lsp operations

  • for code-actions/all is it better to change the tests to include
    nil end selection parameters or stick with the multivarity function?

  • command/call-command also doesn't have an option to end selection,
    but I don't think
    it's possible to use a multivarity function. Is there a better way?

  • documentation for emacs is wrong and I don't have a working lsp-mode
    to shoot a screenshot

  • [ x] I created an issue to discuss the problem I am trying to solve or an open issue already exists.

  • [ x] I added a new entry to CHANGELOG.md

  • [ x] I updated documentation if applicable (docs folder)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant