Extract function selection #2118 #2169
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for code review right now. It adds selection of multiple expressions to extract-function.
TODO:
rename extract-function-2 to something else OR replace existing
extract-function? They behave almost exactly the same. The big issue is that
this requires different parameters (two new ones - the beginning and end of
the selection)
change Calva to handle selection formats from clojure-lsp operations
for code-actions/all is it better to change the tests to include
nil end selection parameters or stick with the multivarity function?
command/call-command also doesn't have an option to end selection,
but I don't think
it's possible to use a multivarity function. Is there a better way?
documentation for emacs is wrong and I don't have a working lsp-mode
to shoot a screenshot
[ x] I created an issue to discuss the problem I am trying to solve or an open issue already exists.
[ x] I added a new entry to CHANGELOG.md
[ x] I updated documentation if applicable (
docsfolder)