fix: validate owner email on platform org creation #26286
Draft
+108
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove isPlatform bypass from owner verification to ensure users can only create organizations where they are the designated owner
Add test coverage for create and intentToCreateOrg handlers: - Regression tests for isPlatform bypass fix - Happy path for admin creating org for another user
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enforces owner email validation for Platform organization creation. Previously, the
isPlatformflag bypassed the owner verification check, allowing organizations to be created with a different user as owner.Changes
isPlatformbypass from owner email check increate.handler.tsisPlatformbypass from owner email check inintentToCreateOrg.handler.tsisPlatformbehaviors preserved (self-serve, company email validation)How to test
/api/trpc/organizations/createwithisPlatform: trueand a different user's email asorgOwnerEmailMandatory Tasks