Skip to content

Conversation

@KartikLabhshetwar
Copy link
Contributor

@KartikLabhshetwar KartikLabhshetwar commented Dec 29, 2025

What does this PR do?

/claim #18987

Visual Demo (For contributors especially)

Video Demo (if applicable):

Screen.Recording.2025-12-29.at.1.50.54.PM.mov

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

Summary by cubic

Routing forms now use the shared event-type field type/config logic, making booking questions consistent and reusable. This also expands supported field types and aligns the query builder and editor with the shared config, addressing CAL-5097 and closing #18987.

  • New Features

    • Adds shared field types (address, url, multiemail, checkbox, radio, boolean) to routing forms.
    • Updates query builder widgets, placeholders, and operators to support these types (e.g., boolean as select; checkbox with multiselect operators).
    • Improves form editor: options are shown only when the field type needs them; boolean defaults to 2 options.
  • Refactors

    • Replaces hard-coded routing form field types with shared fieldTypesForRoutingForms.
    • Centralizes helpers (validation, needsOptions, config) and exposes isFieldTypeWithOptions.
    • Updates attribute-to-field-type mapping and ensures listValues are set only when required.

Written for commit 7633858. Summary will update automatically on new commits.

@vercel
Copy link

vercel bot commented Dec 29, 2025

@KartikLabhshetwar is attempting to deploy a commit to the cal-staging Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added $50 consumer event-types area: event types, event-types routing-forms area: routing forms, routing, forms ✨ feature New feature or request 💎 Bounty A bounty on Algora.io labels Dec 29, 2025
@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Dec 29, 2025
@github-actions github-actions bot added the 🧹 Improvements Improvements to existing features. Mostly UX/UI label Dec 29, 2025
@graphite-app graphite-app bot requested a review from a team December 29, 2025 08:22
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🙋 Bounty claim 💎 Bounty A bounty on Algora.io community Created by Linear-GitHub Sync consumer event-types area: event types, event-types ✨ feature New feature or request 🧹 Improvements Improvements to existing features. Mostly UX/UI routing-forms area: routing forms, routing, forms size/L $50

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CAL-5097] add the same "booking questions" to routing forms

1 participant