Optimize builtins restriction check #28090
Open
+152
−73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`BuiltinRestriction` currently accounts for 9% of the total CPU time for `bazel build --nobuild //src:bazel-dev`. This is avoided by replacing the linear search with a sorted map lookup and avoiding the repeated creation of "non-visible" `RepositoryName` objects, which trigger a `SpellChecker` computation. The map lookup is made possible by the transition to Bzlmod, which makes it possible to drop legacy repo names and treat the remaining apparent repo names as module names, for which it is easy to derive a prefix of the canonical repo name.
Collaborator
Author
|
@bazel-io fork 9.0.0 |
fmeum
requested review from
Wyverald and
gregestren
and removed request for
a team,
gregestren and
lberki
github-actions
bot
added
team-Configurability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BuiltinRestrictioncurrently accounts for 9% of the total CPU time forbazel build --nobuild //src:bazel-dev. This is avoided by replacing the linear search with a sorted map lookup and avoiding the repeated creation of "non-visible"RepositoryNameobjects, which trigger aSpellCheckercomputation.The map lookup is made possible by the transition to Bzlmod, which makes it possible to drop legacy repo names and treat the remaining apparent repo names as module names, for which it is easy to derive an unambiguous prefix of the canonical repo name.