Skip to content

fix: Move expires_in field after scope in OAuth2 configuration (#31059) #41480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
DevXSoni021 wants to merge 1 commit into
base: release
Choose a base branch
from
Open

fix: Move expires_in field after scope in OAuth2 configuration (#31059) #41480

DevXSoni021 wants to merge 1 commit into from

Conversation

@DevXSoni021
Copy link

@DevXSoni021 DevXSoni021 commented Dec 20, 2025 •
edited
Loading

Removed the 'Authorization expires in (seconds)' input field from the RestAPIDatasourceForm.

Description

Tip

Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).

Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags=""

🔍 Cypress test results

Caution

If you modify the content in this section, you are likely to disrupt the CI result for your PR.

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • Bug Fixes
    • Removed the Authorization expires in (seconds) configuration field from OAuth2 Authorization Code flow settings, streamlining the advanced OAuth2 setup interface.

✏️ Tip: You can customize this high-level summary in your review settings.

@DevXSoni021
Remove expiresIn input field from authentication form
77999bc 
Removed the 'Authorization expires in (seconds)' input field from the RestAPIDatasourceForm.
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 20, 2025 •
edited
Loading

Walkthrough

Removed the UI input field for configuring authorization token expiry duration from the OAuth2 Authorization Code flow settings form. This eliminates the NUMBER-type form control in the advanced OAuth2 configuration section.

Changes

Cohort / File(s) Change Summary
OAuth2 Form Field Removal
app/client/src/pages/Editor/DataSourceEditor/RestAPIDatasourceForm.tsx		 Deleted the authentication.expiresIn form control from the Authorization Code section, removing the ability to manually configure token expiry duration (in seconds) through the UI.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Straightforward removal of a single form field with no logic or control flow implications

Poem

⏰ One less field in the OAuth dance,
Expiry times need not advance,
Simpler settings, cleaner code,
Authorization takes the lighter load! 🔐

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Title check ⚠️ Warning The title states 'Move expires_in field after scope' but the actual change removed the field entirely, not relocated it. Update title to accurately reflect the change: 'fix: Remove expires_in field from OAuth2 configuration' or similar.
Description check ⚠️ Warning The PR description lacks critical details: no issue number/URL is provided, motivation and context are missing, and dependencies are not documented. Add the issue number or URL that this fixes, provide motivation for removing the field, and explain any impacts on existing configurations or users.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Dec 28, 2025

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

@github-actions github-actions bot added the Stale label Dec 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@DevXSoni021