Skip to content

Conversation

@pvillard31
Copy link
Contributor

Summary

NIFI-15381 - Improve UX for the view Show/Revert Local Changes to account for environmental changes

Issue description

As part of the change in NIFI-14442, when listing local changes we are also listing the fact that bundle versions may have changed as part of an upgrade and that it'll be part of the commit.

However we are also going to show those changes when clicking "revert local changes" in the UI but those changes should not be listed since we are NOT going to revert this as part of the action.

However it can get tricky... those changes can be environmental because we upgraded the NiFi version and the component NAR went from X to Y automatically as part of the upgrade. But we could also have a bundle version change as the result of a manual action from the user when you have multiple versions of the same NAR in NiFi. In this case changing the version is not an environmental change and the user could indeed revert that version change.

So we need to improve the logic around all of this to have the proper UX and show only the list of things that would effectively be reverted if reverting local changes. And when listing local changes, we should add a checkbox to hide/display changes that are environmental but not the result of a user action.

Changes

The "Show local changes" view now displays a checkbox to show (default) / hide environmental changes:

Screenshot 2025-12-22 at 15 43 29 Screenshot 2025-12-22 at 15 43 36

The "Revert local changes" is hiding the changes that would not be reverted:

Screenshot 2025-12-22 at 15 43 51

If the version change was user-initiated because you have multiple versions of the NAR, then it would not be showing as an environmental change and the revert is actually possible (and working).

Screenshot 2025-12-22 at 15 52 04

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using ./mvnw clean install -P contrib-check
    • JDK 21
    • JDK 25

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@pvillard31 pvillard31 added the ui Pull requests for work relating to the user interface label Dec 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ui Pull requests for work relating to the user interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant