NIFI-15381 - Improve UX for the view Show/Revert Local Changes to account for environmental changes #10681
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-15381 - Improve UX for the view Show/Revert Local Changes to account for environmental changes
Issue description
As part of the change in NIFI-14442, when listing local changes we are also listing the fact that bundle versions may have changed as part of an upgrade and that it'll be part of the commit.
However we are also going to show those changes when clicking "revert local changes" in the UI but those changes should not be listed since we are NOT going to revert this as part of the action.
However it can get tricky... those changes can be environmental because we upgraded the NiFi version and the component NAR went from X to Y automatically as part of the upgrade. But we could also have a bundle version change as the result of a manual action from the user when you have multiple versions of the same NAR in NiFi. In this case changing the version is not an environmental change and the user could indeed revert that version change.
So we need to improve the logic around all of this to have the proper UX and show only the list of things that would effectively be reverted if reverting local changes. And when listing local changes, we should add a checkbox to hide/display changes that are environmental but not the result of a user action.
Changes
The "Show local changes" view now displays a checkbox to show (default) / hide environmental changes:
The "Revert local changes" is hiding the changes that would not be reverted:
If the version change was user-initiated because you have multiple versions of the NAR, then it would not be showing as an environmental change and the revert is actually possible (and working).
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation