Refactoring of the project creation component to enable domain, account, and user specification#12646
Open
erikbocks wants to merge 1 commit intoapache:mainfrom
Open
Conversation
…nt, and user specification
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12646 +/- ##
============================================
+ Coverage 16.26% 17.89% +1.62%
- Complexity 13428 16092 +2664
============================================
Files 5660 5939 +279
Lines 499963 532899 +32936
Branches 60708 65196 +4488
============================================
+ Hits 81330 95371 +14041
- Misses 409559 426850 +17291
- Partials 9074 10678 +1604
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16839 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, it is not possible to specify in the GUI which domain that the project will be created in, neither the account or the user that will be assigned as the project owner, automatically assigning the project to the current user. The project creation component was refactored to allow the specification of the domain, account or user of the project during the project creation.
The current user's account and domain are automatically selected. If the current user does not belong to the selected domain, the first account returned in the listing is selected.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Screenshots (if appropriate):
Projects created with the new form
How Has This Been Tested?
First, the
subdomaindomain was created, thenormalrootaccount was created in theROOTdomain, and thesubdomainuseraccount was created in thesubdomaindomain. ThesubDomainAnotherUseruser was also created in thesubdomainuseraccount. Then, using the new project creation component, I created the following projects:ROOTdomain with theadminaccount as the owner;ROOTdomain with thenormalrootaccount as the owner;subdomaindomain with thesubdomainuseraccount as the owner;subdomaindomain with thesubDomainAnotherUseruser from thesubdomainuseraccount as the owner.Logged in as a normal user, I validated that the ownership selection component was not shown, and when the project was created, it was automatically assigned to the current account.
I also validated that other features flows that use the
OwnershipSelectioncomponent (VM deployment, VM assignment and Guest Network creation) were not affected by the changes.