Skip to content

Conversation

@bencap
Copy link
Collaborator

@bencap bencap commented Dec 16, 2025

This pull request adds support for associating external links with experiments in the database and view models, and refactors related Pydantic models for better code reuse. The main changes are the addition of an external_links property to experiments, the introduction of a reusable ExternalLink model, and the relocation of the OfficialCollection model for consistency.

Database and Model Changes:

  • Added a new external_links column of type JSONB (not nullable) to the experiments table via Alembic migration.
  • Updated the Experiment SQLAlchemy model to include the new external_links column with a default empty dictionary.

Pydantic Model Refactoring:

  • Introduced a reusable ExternalLink Pydantic model in components/external_link.py and updated references in experiment and score set view models to use this shared model. [1] [2] [3] [4]
  • Moved the OfficialCollection model to collection.py for consistency, and updated imports throughout the codebase. [1] [2] [3] [4]

Code Cleanup:

  • Removed duplicate definitions of ExternalLink and OfficialCollection from score_set.py and experiment.py, ensuring these models are only defined once and imported where needed. [1] [2]
  • Minor import ordering and typing improvements in affected files. [1] [2]

@bencap bencap requested review from jstone-dev and sallybg December 16, 2025 20:26
@bencap bencap linked an issue Dec 16, 2025 that may be closed by this pull request
@bencap bencap force-pushed the feature/bencap/606/igvf-dedicated-linkout branch 2 times, most recently from 1fa397e to f9a8f74 Compare December 16, 2025 21:34
bencap added a commit to VariantEffect/mavedb-ui that referenced this pull request Dec 16, 2025
@bencap bencap force-pushed the feature/bencap/606/igvf-dedicated-linkout branch from f9a8f74 to 017cebe Compare December 16, 2025 22:07
@bencap bencap force-pushed the feature/bencap/606/igvf-dedicated-linkout branch from 017cebe to 90f1da2 Compare December 16, 2025 23:04
…omponents

Adds a new `components/` directory to the view models directory which is intended to house shared components. Refactors the official collection component into the `collections` view model folder, which is more appropriate given the content.
@bencap bencap force-pushed the feature/bencap/606/igvf-dedicated-linkout branch from 90f1da2 to 9dbcd77 Compare December 16, 2025 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IGVF Dedicated Linkout

2 participants