Skip to content

chore: bump default kube version to 1.34 in tests #44700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
lavigne958 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: bump default kube version to 1.34 in tests #44700

lavigne958 wants to merge 1 commit into from
+58 −10

Conversation

@lavigne958
Copy link
Contributor

@lavigne958 lavigne958 commented Dec 31, 2025

What does this PR do?

add a new option to e2e-framework for gke cluster to specify the kubernetes version.

Bump default version in Pulumi defaults to 1.34

Motivation

allow testing of latest kube version using gcp.gke

Describe how you validated your changes

run the command

dda inv gcp.deploy-gke -k 1.35

cluster successfully deployed.

Additional Notes

This bumps default kubernetes version in tests

@lavigne958 lavigne958 self-assigned this Dec 31, 2025
@lavigne958 lavigne958 requested a review from a team as a code owner December 31, 2025 15:03
@lavigne958 lavigne958 added kind/enhancement dev/testing changelog/no-changelog category/improvement qa/done QA done before merge and regressions are covered by tests ask-review Ask required teams to review this PR qa/skip-qa team/agent-devx labels Dec 31, 2025
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Dec 31, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 31, 2025 •
edited
Loading

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 56f5e9c
📊 Static Quality Gates Dashboard

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
✅ agent_deb_amd64 $${0}$$ $${708.39}$$ < $${708.41}$$ $${+0}$$ $${173.94}$$ < $${174.49}$$
✅ agent_deb_amd64_fips $${0}$$ $${703.68}$$ < $${704.0}$$ $${-0.09}$$ $${172.64}$$ < $${173.75}$$
✅ agent_heroku_amd64 $${0}$$ $${328.83}$$ < $${329.53}$$ $${+0.01}$$ $${87.45}$$ < $${88.45}$$
✅ agent_msi $${+0}$$ $${570.98}$$ < $${982.08}$$ $${+0.02}$$ $${142.75}$$ < $${143.02}$$
✅ agent_rpm_amd64 $${0}$$ $${708.38}$$ < $${708.38}$$ $${+0.01}$$ $${176.42}$$ < $${177.66}$$
✅ agent_rpm_amd64_fips $${0}$$ $${703.67}$$ < $${703.99}$$ $${+0}$$ $${175.9}$$ < $${176.6}$$
✅ agent_rpm_arm64 $${+0}$$ $${689.93}$$ < $${693.52}$$ $${+0.04}$$ $${160.0}$$ < $${161.26}$$
✅ agent_rpm_arm64_fips $${0}$$ $${686.06}$$ < $${688.48}$$ $${+0.03}$$ $${159.38}$$ < $${160.55}$$
✅ agent_suse_amd64 $${0}$$ $${708.38}$$ < $${708.38}$$ $${+0.01}$$ $${176.42}$$ < $${177.66}$$
✅ agent_suse_amd64_fips $${0}$$ $${703.67}$$ < $${703.99}$$ $${+0}$$ $${175.9}$$ < $${176.6}$$
✅ agent_suse_arm64 $${+0}$$ $${689.93}$$ < $${693.52}$$ $${+0.04}$$ $${160.0}$$ < $${161.26}$$
✅ agent_suse_arm64_fips $${0}$$ $${686.06}$$ < $${688.48}$$ $${+0.03}$$ $${159.38}$$ < $${160.55}$$
✅ docker_agent_amd64 $${-0}$$ $${770.18}$$ < $${770.72}$$ $${+0}$$ $${261.8}$$ < $${262.45}$$
✅ docker_agent_arm64 $${+0}$$ $${776.3}$$ < $${780.2}$$ $${-0.01}$$ $${250.84}$$ < $${252.63}$$
✅ docker_agent_jmx_amd64 $${+0}$$ $${961.06}$$ < $${961.6}$$ $${-0}$$ $${330.43}$$ < $${331.08}$$
✅ docker_agent_jmx_arm64 $${+0}$$ $${955.9}$$ < $${959.8}$$ $${-0}$$ $${315.46}$$ < $${317.27}$$
✅ docker_cluster_agent_amd64 $${+0}$$ $${180.72}$$ < $${181.08}$$ $${+0}$$ $${63.85}$$ < $${64.49}$$
✅ docker_cluster_agent_arm64 $${-0}$$ $${196.55}$$ < $${198.49}$$ $${0}$$ $${60.12}$$ < $${61.17}$$
✅ docker_cws_instrumentation_amd64 $${0}$$ $${7.13}$$ < $${7.18}$$ $${-0}$$ $${2.99}$$ < $${3.33}$$
✅ docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${0}$$ $${2.73}$$ < $${3.09}$$
✅ docker_dogstatsd_amd64 $${+0}$$ $${38.81}$$ < $${39.38}$$ $${-0}$$ $${15.02}$$ < $${15.82}$$
✅ docker_dogstatsd_arm64 $${+0}$$ $${37.13}$$ < $${37.94}$$ $${+0}$$ $${14.34}$$ < $${14.83}$$
✅ dogstatsd_deb_amd64 $${0}$$ $${30.03}$$ < $${30.61}$$ $${-0}$$ $${7.94}$$ < $${8.79}$$
✅ dogstatsd_deb_arm64 $${0}$$ $${28.18}$$ < $${29.11}$$ $${+0}$$ $${6.82}$$ < $${7.71}$$
✅ dogstatsd_rpm_amd64 $${0}$$ $${30.03}$$ < $${30.61}$$ $${-0}$$ $${7.95}$$ < $${8.8}$$
✅ dogstatsd_suse_amd64 $${0}$$ $${30.03}$$ < $${30.61}$$ $${-0}$$ $${7.95}$$ < $${8.8}$$
✅ iot_agent_deb_amd64 $${0}$$ $${42.97}$$ < $${43.29}$$ $${-0}$$ $${11.25}$$ < $${12.04}$$
✅ iot_agent_deb_arm64 $${0}$$ $${40.1}$$ < $${40.92}$$ $${+0}$$ $${9.62}$$ < $${10.45}$$
✅ iot_agent_deb_armhf $${0}$$ $${40.68}$$ < $${41.03}$$ $${-0}$$ $${9.81}$$ < $${10.62}$$
✅ iot_agent_rpm_amd64 $${0}$$ $${42.98}$$ < $${43.29}$$ $${+0}$$ $${11.27}$$ < $${12.06}$$
✅ iot_agent_suse_amd64 $${0}$$ $${42.98}$$ < $${43.29}$$ $${+0}$$ $${11.27}$$ < $${12.06}$$

@cit-pr-commenter
Copy link

cit-pr-commenter bot commented Dec 31, 2025 •
edited
Loading

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 8195c074-fa28-4638-8112-6610dc625a0e

Baseline: e6cb7d2
Comparison: 4368122
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
➖ docker_containers_cpu % cpu utilization +2.82 [-0.17, +5.80] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ docker_containers_cpu % cpu utilization +2.82 [-0.17, +5.80] 1 Logs
➖ tcp_syslog_to_blackhole ingress throughput +1.14 [+1.06, +1.21] 1 Logs
➖ docker_containers_memory memory utilization +0.61 [+0.53, +0.68] 1 Logs
➖ ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.31 [+0.07, +0.54] 1 Logs
➖ otlp_ingest_logs memory utilization +0.29 [+0.18, +0.39] 1 Logs
➖ quality_gate_idle_all_features memory utilization +0.17 [+0.13, +0.21] 1 Logs bounds checks dashboard
➖ file_to_blackhole_0ms_latency egress throughput +0.05 [-0.35, +0.44] 1 Logs
➖ ddot_metrics_sum_delta memory utilization +0.02 [-0.19, +0.23] 1 Logs
➖ otlp_ingest_metrics memory utilization +0.01 [-0.14, +0.16] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput +0.01 [-0.07, +0.09] 1 Logs
➖ file_tree memory utilization +0.01 [-0.05, +0.06] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput +0.01 [-0.12, +0.13] 1 Logs
➖ uds_dogstatsd_to_api_v3 ingress throughput -0.01 [-0.14, +0.13] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput -0.03 [-0.08, +0.02] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput -0.03 [-0.41, +0.34] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput -0.04 [-0.47, +0.39] 1 Logs
➖ ddot_metrics_sum_cumulative memory utilization -0.12 [-0.29, +0.04] 1 Logs
➖ ddot_metrics memory utilization -0.15 [-0.39, +0.08] 1 Logs
➖ quality_gate_idle memory utilization -0.17 [-0.22, -0.12] 1 Logs bounds checks dashboard
➖ uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.25 [-0.30, -0.19] 1 Logs
➖ ddot_logs memory utilization -0.72 [-0.79, -0.65] 1 Logs
➖ quality_gate_metrics_logs memory utilization -0.79 [-0.99, -0.60] 1 Logs bounds checks dashboard
➖ quality_gate_logs % cpu utilization -3.71 [-5.16, -2.27] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
✅ docker_containers_cpu simple_check_run 10/10
✅ docker_containers_memory memory_usage 10/10
✅ docker_containers_memory simple_check_run 10/10
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency lost_bytes 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_logs lost_bytes 10/10 bounds checks dashboard
✅ quality_gate_logs memory_usage 10/10 bounds checks dashboard
✅ quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
✅ quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
✅ quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@github-actions github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Jan 2, 2026
@lavigne958
Copy link
Contributor Author

lavigne958 commented Jan 2, 2026

Note:

The bump require a tiny addition:

  • we need to parse the newer kubernetes versions from the new k8s_versions.json file

@lavigne958
chore: bump default kube version to 1.34 in tests
4368122 
add a new option to e2e-framework for gke cluster to specify the
kubernetes version.

Bump default version in Pulumi defaults to 1.34

Signed-off-by: Alexandre Lavigne <[email protected]>
@lavigne958 lavigne958 force-pushed the crayon/add_kube_version_option_to_gke_deploy branch from ce4b4dd to 4368122 Compare January 2, 2026 15:46
@lavigne958
Copy link
Contributor Author

lavigne958 commented Jan 2, 2026

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Jan 2, 2026 •
edited
Loading

View all feedbacks in Devflow UI.

2026-01-02 15:47:14 UTC ℹ️ Start processing command /merge

2026-01-02 15:47:19 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2026-01-02 16:08:46 UTC ⚠️ MergeQueue: This merge request was unqueued

[email protected] unqueued this merge request

@lavigne958
Copy link
Contributor Author

lavigne958 commented Jan 2, 2026

/merge --cancel

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Jan 2, 2026 •
edited
Loading

View all feedbacks in Devflow UI.

2026-01-02 16:08:42 UTC ℹ️ Start processing command /merge --cancel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chouetz chouetz chouetz approved these changes

Assignees

@lavigne958 lavigne958

Labels

ask-review Ask required teams to review this PR category/improvement changelog/no-changelog dev/testing kind/enhancement medium review PR review might take time qa/done QA done before merge and regressions are covered by tests qa/skip-qa team/agent-devx

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lavigne958 @chouetz