Conversation
thebaer
left a comment
thebaer
left a comment
There was a problem hiding this comment.
Thanks for submitting this! I think it'd make a great addition. Just a couple changes needed and we can merge this.
| Hidden: true, | ||
| }, | ||
| &cli.StringFlag{ | ||
| Name: "silence-user", |
There was a problem hiding this comment.
We kept old flags in here only for backwards compatibility. Ideally we'd move away from this older style, so we don't need to add new commands here.
| return writefreely.CreateUser(app, username, password, false) | ||
| case c.IsSet("delete-user"): | ||
| return writefreely.DoDeleteAccount(app, c.String("delete-user")) | ||
| case c.IsSet("silence-user"): |
There was a problem hiding this comment.
Same here -- no need to check for this flag.
| } | ||
|
|
||
| log.Info("Silencing...") | ||
| err = apper.App().db.SilenceAccount(userID) |
There was a problem hiding this comment.
I think ideally we should use the existing datastore.SetUserStatus() method instead of creating a new one here, to keep things maintainable.
|
Thanks for the review Matt. Agreed on all points. It's hard to deduce the direction of code from existing stuff, so I took the lazy route and just did a 'copy-pasta' first to get it to work and allow me to manage some abuse on qua.name. I'll be returning to this PR after returning from travel. I'll set state to WIP after I find out where to click. |
|
No problem, @mrvdb. Any progress on this? |
|
Haven't been revisiting it yet. |
|
@mrvdb I'm hoping to get the next release out within the next week or two, so if you can make those changes before then, we'll include them in v0.13! Otherwise we can include it in the following release. |
|
Sorry, I won't have the opportunity in the foreseeable future to spent time on this. Feel free to remove or complete as you see fit. |
|
No problem, thanks for letting me know! |
2 participants
Add user silencing to CLI
Quick implementation. Ideally unsilence should be there as well and for scriptability a 'no-confirm' flag of some sort would be nice.