fix coverage of files included with a relative path#330
Open
beatussum wants to merge 1 commit intoshellspec:masterfrom
Open
fix coverage of files included with a relative path#330beatussum wants to merge 1 commit intoshellspec:masterfrom
beatussum wants to merge 1 commit intoshellspec:masterfrom
Conversation
Before this commit, if a specfile includes (`Include`) a file foo with a relative path and the directory from where `shellspec` is called differs from the one specified by `--execdir`, foo is not covered with `--kcov`. Closes: shellspec#327 See-also: shellspec#327 Signed-off-by: Mattéo Rossillol‑‑Laruelle <[email protected]>
Member
|
Thanks for the contribution. I have not yet looked into this issue in detail and cannot get to it immediately. Please wait a little while. (If there are no problems with this modification) the location of the test code for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request should close this issue.
I'm totally not sure if the
shellspec_execdir()moving yet respects the project hierarchy.All tests passed and waiting for review!