Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Welcome @jhbae200!

It looks like this is your first PR to kubernetes-client/java 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/java has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@jhbae200 thank you for kicking this off! can you resign your commit by properly setting up your git workspace?

git config user.name ..
git config user.email ...

/check-cla

/assign @yue9944882

Some small comments. Generally looks good. Needs linter formatting to conform to the style guide.

Updated the code. am i right?

Code looks great.

Can you add a unit test for this new functionality (sorry, I should have mentioned that before).

Once it is tested (and passing) we can merge.

I think need to mock the ProcessBuilder to test the refresh method.
I'm trying to mock that function by adding a getProcessBuilder method to this class. What do you think?

public class GCPAuthenticator implements Authenticator {
//somthing code
  public ProcessBuilder getPb() {
    return new ProcessBuilder();
  }

  @Override
  public Map<String, Object> refresh(Map<String, Object> config) {
    //somthing code
      Process process = this.getPb().command(Arrays.asList(fullCmd.split(" "))).start();
    //somthing code
  }
}

Thanks for adding the test!

I think it is simpler if you just make the ProcessBuilder an optional constructor parameter, e.g.

public GCPAuthenticator() {
   this(new ProcessBuilder());
}

public GCPAuthenticator(ProcessBuilder pb) {
   this.pb = pb;
}
....

/lgtm
/approve

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, jhbae200

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Great to have it implemented!

Are there any plans to release it in the near future?

It took me a while to discover that this existed and was released. Any chance this can be added to the documentation for those coming after me?

Thanks