chore: fixed incorrect typecast in DefaultStatsFactoryPlugin#19156
Merged
Conversation
The committers listed above are authorized under a signed CLA. |
Contributor
|
For maintainers only:
|
Andarist
commented
Jan 22, 2025
| // So it should always end up being smaller | ||
| const headerSize = group.filteredChildren ? 2 : 1; | ||
| const limited = spaceLimited( | ||
| /** @type {Children<T>} */ (group.children), |
Contributor
Author
There was a problem hiding this comment.
This is an error with TS 5.4, TS 5.5 introduced a bug that accidentally allows this call. At some point, that bug will get fixed (microsoft/TypeScript#61013) so it would be good to fix this code before that happens :)
alexander-akait
approved these changes
Feb 4, 2025
Member
|
Thanks |
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This is just a small internal correction.
Did you add tests for your changes?
No. They are not needed
Does this PR introduce a breaking change?
No.
What needs to be documented once your changes are merged?
Nothing.