Make CommonJS import preserve chained expressions #17718

bworline · 2023-10-01T05:16:26Z

Summary

This is a follow-on to #17203 which handled harmony imports. This PR handles commonjs imports. This chained expression handling is required for Closure Compiler operation in ADVANCED mode. Fixes #17723.

`🤖 Generated by Copilot at b14922c`

This pull request refactors the code generation and dependency handling of webpack for commonjs and harmony imports with chained ids. It introduces a new utility function getTrimmedIdsAndRange in lib/util/chainedImports.js to simplify and unify the logic for trimming ids. It also updates and adds test cases to verify the output quality and coverage.

Details

`🤖 Generated by Copilot at b14922c`

Refactor the logic for trimming ids from different types of dependencies into a separate module and a common function getTrimmedIdsAndRange (link, link, link)
Add a new parameter idRanges to the CommonJsFullRequireDependency constructor and the related hook handlers, and make it optional for backward compatibility (link, link, link, link, link, link)
Update the serialization and deserialization logic of the CommonJsFullRequireDependency class to include the idRanges property (link, link)
Update the apply method of the CommonJsFullRequireDependency class to use the getTrimmedIdsAndRange function and the idRanges property for computing and replacing the trimmed ids and range (link, link)
Update the chainHandler and callChainHandler functions in the CommonJsImportsParserPlugin class to pass the idRanges parameter to the CommonJsFullRequireDependency constructor (link, link)
Update the apply method of the HarmonyImportSpecifierDependency class to use the getTrimmedIdsAndRange function for computing the trimmed ids and range (link)
Remove the unused _trimIdsToThoseImported method from the HarmonyImportSpecifierDependency class (link)
Update the walkMemberExpression and walkCallExpression methods of the JavascriptParser class to pass the memberRanges parameter to the hook handlers (link, link)
Add some new test cases to the test/configCases/code-generation/re-export-namespace-concat/index.js and test/configCases/code-generation/re-export-namespace/index.js files to check the behavior of webpack when re-exporting namespaces with concatenated ids (link, link)
Update the expected output of the test cases in the test/configCases/code-generation/re-export-namespace-concat/index.js and test/configCases/code-generation/re-export-namespace/index.js files to reflect the changes made by the refactoring and the feature of trimming ids (link, link)

webpack-bot · 2023-10-01T05:16:32Z

For maintainers only:

This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
This needs to be backported to webpack 4 (issue will be created when merged)

bworline · 2023-10-02T18:23:38Z

@TheLarkInn can you take a look? Thanks!

TheLarkInn · 2023-10-13T19:07:15Z

Thank you for this fix <3

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [webpack](https://togithub.com/webpack/webpack) | devDependencies | minor | [`5.88.2` -> `5.89.0`](https://renovatebot.com/diffs/npm/webpack/5.88.2/5.89.0) | --- ### Release Notes <details> <summary>webpack/webpack (webpack)</summary> ### [`v5.89.0`](https://togithub.com/webpack/webpack/releases/tag/v5.89.0) [Compare Source](https://togithub.com/webpack/webpack/compare/v5.88.2...v5.89.0) #### New Features - Make CommonJS import preserve chained expressions by [@bworline](https://togithub.com/bworline) in [https://github.com/webpack/webpack/pull/17718](https://togithub.com/webpack/webpack/pull/17718) #### Dependencies & Maintenance - chore(deps-dev): bump [@types/node](https://togithub.com/types/node) from 20.3.1 to 20.4.8 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/webpack/webpack/pull/17568](https://togithub.com/webpack/webpack/pull/17568) - docs: add example for stats detailed output by [@ersachin3112](https://togithub.com/ersachin3112) in [https://github.com/webpack/webpack/pull/17420](https://togithub.com/webpack/webpack/pull/17420) - docs: add example for stats normal output by [@ersachin3112](https://togithub.com/ersachin3112) in [https://github.com/webpack/webpack/pull/17426](https://togithub.com/webpack/webpack/pull/17426) - chore(deps-dev): bump core-js from 3.31.0 to 3.32.0 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/webpack/webpack/pull/17539](https://togithub.com/webpack/webpack/pull/17539) - chore(deps-dev): bump pretty-format from 29.5.0 to 29.6.2 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/webpack/webpack/pull/17536](https://togithub.com/webpack/webpack/pull/17536) - chore(deps-dev): bump [@types/node](https://togithub.com/types/node) from 20.4.8 to 20.4.9 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/webpack/webpack/pull/17583](https://togithub.com/webpack/webpack/pull/17583) - chore(deps-dev): bump less from 4.1.3 to 4.2.0 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/webpack/webpack/pull/17580](https://togithub.com/webpack/webpack/pull/17580) - chore(deps): bump semver from 5.7.1 to 5.7.2 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/webpack/webpack/pull/17483](https://togithub.com/webpack/webpack/pull/17483) - chore(deps-dev): bump simple-git from 3.19.0 to 3.19.1 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/webpack/webpack/pull/17427](https://togithub.com/webpack/webpack/pull/17427) - chore(deps-dev): bump [@types/node](https://togithub.com/types/node) from 20.4.9 to 20.6.0 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/webpack/webpack/pull/17666](https://togithub.com/webpack/webpack/pull/17666) **Full Changelog**: webpack/webpack@v5.88.2...v5.89.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).  Co-authored-by: Renovate Bot <[email protected]>

initial

d4e8485

webpack-bot added the PR: unreviewed label Oct 1, 2023

bworline added 3 commits September 30, 2023 22:22

update types

d36804e

update types

dc66572

Refactor shared code

b14922c

bworline mentioned this pull request Oct 3, 2023

CommonJS imports should preserve chained expressions #17723

Closed

bworline changed the title ~~Preserve chained expressions; commonjs import of harmony export~~ Preserve chained expressions; CommonJS import of Harmony export Oct 3, 2023

bworline changed the title ~~Preserve chained expressions; CommonJS import of Harmony export~~ CommonJS import preserved chained expressions Oct 3, 2023

bworline changed the title ~~CommonJS import preserved chained expressions~~ CommonJS import preserves chained expressions Oct 3, 2023

bworline changed the title ~~CommonJS import preserves chained expressions~~ Make CommonJS import preserve chained expressions Oct 3, 2023

hexiaokang approved these changes Oct 6, 2023

View reviewed changes

TheLarkInn approved these changes Oct 13, 2023

View reviewed changes

webpack-bot added PR: reviewed-approved and removed PR: unreviewed labels Oct 13, 2023

TheLarkInn merged commit 21c80e4 into webpack:main Oct 13, 2023

X-oss-byte mentioned this pull request Sep 27, 2024

[Snyk] Upgrade webpack from 5.82.1 to 5.94.0 X-oss-byte/webpack-dev-server#129

Open

peterleiva mentioned this pull request Sep 27, 2024

[Snyk] Upgrade webpack from 5.67.0 to 5.94.0 peterleiva/webpack-config-organizer#187

Open

Tanver-Hasan mentioned this pull request Sep 27, 2024

[Snyk] Upgrade webpack from 5.11.0 to 5.94.0 Tanver-Hasan/nextjs-boilerplate#2012

Open

q1blue mentioned this pull request Sep 27, 2024

[Snyk] Upgrade webpack from 5.10.0 to 5.94.0 https-quantumblockchainai-atlassian-net/karma-webpack-33d72f79#264

Open

nejidevelops mentioned this pull request Sep 28, 2024

[Snyk] Upgrade webpack from 5.88.2 to 5.94.0 nejidevelops/LeaderBoard#72

Open

q1blue mentioned this pull request Sep 28, 2024

[Snyk] Upgrade webpack from 5.10.0 to 5.94.0 https-quantumblockchainai-atlassian-net/karma-webpack-33d72f79#265

Open

Tanver-Hasan mentioned this pull request Sep 28, 2024

[Snyk] Upgrade webpack from 5.11.0 to 5.94.0 Tanver-Hasan/nextjs-boilerplate#2015

Open

peterleiva mentioned this pull request Sep 28, 2024

[Snyk] Upgrade webpack from 5.67.0 to 5.94.0 peterleiva/webpack-config-organizer#188

Open

Tanver-Hasan mentioned this pull request Sep 29, 2024

[Snyk] Upgrade webpack from 5.11.0 to 5.94.0 Tanver-Hasan/nextjs-boilerplate#2016

Open

X-oss-byte mentioned this pull request Sep 29, 2024

[Snyk] Upgrade webpack from 5.82.1 to 5.94.0 X-oss-byte/webpack-dev-server#130

Open

veenone mentioned this pull request Sep 30, 2024

[Snyk] Upgrade webpack from 5.76.1 to 5.94.0 veenone/snipe-it#10

Open

q1blue mentioned this pull request Sep 30, 2024

[Snyk] Upgrade webpack from 5.10.0 to 5.94.0 https-quantumblockchainai-atlassian-net/karma-webpack-33d72f79#266

Open

nejidevelops mentioned this pull request Oct 1, 2024

[Snyk] Upgrade webpack from 5.88.2 to 5.94.0 nejidevelops/LeaderBoard#73

Open

peterleiva mentioned this pull request Oct 1, 2024

[Snyk] Upgrade webpack from 5.67.0 to 5.94.0 peterleiva/webpack-config-organizer#189

Open

Tanver-Hasan mentioned this pull request Oct 1, 2024

[Snyk] Upgrade webpack from 5.11.0 to 5.94.0 Tanver-Hasan/nextjs-boilerplate#2017

Open

X-oss-byte mentioned this pull request Oct 1, 2024

[Snyk] Upgrade webpack from 5.82.1 to 5.94.0 X-oss-byte/webpack-dev-server#131

Open

Tanver-Hasan mentioned this pull request Oct 2, 2024

[Snyk] Upgrade webpack from 5.11.0 to 5.94.0 Tanver-Hasan/nextjs-boilerplate#2019

Open

peterleiva mentioned this pull request Oct 2, 2024

[Snyk] Upgrade webpack from 5.67.0 to 5.94.0 peterleiva/webpack-config-organizer#190

Open

q1blue mentioned this pull request Oct 2, 2024

[Snyk] Upgrade webpack from 5.10.0 to 5.94.0 https-quantumblockchainai-atlassian-net/karma-webpack-33d72f79#267

Open

X-oss-byte mentioned this pull request Oct 2, 2024

[Snyk] Upgrade webpack from 5.82.1 to 5.94.0 X-oss-byte/webpack-dev-server#132

Open

nejidevelops mentioned this pull request Oct 2, 2024

[Snyk] Upgrade webpack from 5.88.2 to 5.94.0 nejidevelops/LeaderBoard#74

Open

InfiniteLove2020 mentioned this pull request Oct 3, 2024

[Snyk] Upgrade webpack from 4.44.0 to 5.94.0 InfiniteLove2020/docs-2#7

Open

q1blue mentioned this pull request Oct 3, 2024

[Snyk] Upgrade webpack from 5.10.0 to 5.94.0 https-quantumblockchainai-atlassian-net/karma-webpack-33d72f79#268

Open

Tanver-Hasan mentioned this pull request Oct 4, 2024

[Snyk] Upgrade webpack from 5.11.0 to 5.94.0 Tanver-Hasan/nextjs-boilerplate#2021

Open

peterleiva mentioned this pull request Oct 4, 2024

[Snyk] Upgrade webpack from 5.67.0 to 5.94.0 peterleiva/webpack-config-organizer#191

Open

q1blue mentioned this pull request Oct 4, 2024

[Snyk] Upgrade webpack from 5.10.0 to 5.94.0 https-quantumblockchainai-atlassian-net/karma-webpack-33d72f79#269

Open

X-oss-byte mentioned this pull request Oct 4, 2024

[Snyk] Upgrade webpack from 5.82.1 to 5.94.0 X-oss-byte/webpack-dev-server#133

Open

nejidevelops mentioned this pull request Oct 4, 2024

[Snyk] Upgrade webpack from 5.88.2 to 5.94.0 nejidevelops/LeaderBoard#75

Open

q1blue mentioned this pull request Oct 7, 2024

[Snyk] Upgrade webpack from 5.10.0 to 5.94.0 https-quantumblockchainai-atlassian-net/karma-webpack-33d72f79#270

Open

peterleiva mentioned this pull request Oct 8, 2024

[Snyk] Upgrade webpack from 5.67.0 to 5.94.0 peterleiva/webpack-config-organizer#192

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Make CommonJS import preserve chained expressions #17718

Make CommonJS import preserve chained expressions #17718

Uh oh!

bworline commented Oct 1, 2023 •

edited

Loading

Uh oh!

webpack-bot commented Oct 1, 2023

Uh oh!

bworline commented Oct 2, 2023 •

edited

Loading

Uh oh!

TheLarkInn commented Oct 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Make CommonJS import preserve chained expressions #17718

Make CommonJS import preserve chained expressions #17718

Uh oh!

Conversation

bworline commented Oct 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

🤖 Generated by Copilot at b14922c

Details

🤖 Generated by Copilot at b14922c

Uh oh!

webpack-bot commented Oct 1, 2023

Uh oh!

bworline commented Oct 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TheLarkInn commented Oct 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bworline commented Oct 1, 2023 •

edited

Loading

`🤖 Generated by Copilot at b14922c`

`🤖 Generated by Copilot at b14922c`

bworline commented Oct 2, 2023 •

edited

Loading