feat(mvt): add attribute controller to MVT requests #5732
+1,563
−500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed example wget command and redundant note about placeholder encoding.
Member
I like the idea! But could you please target this PR against my branch? 😄 Otherwise it is difficult to understand what was changed 😄 |
Member
Author
|
Yeah I figured this'll be a future PR after merging the other one. But if it'll be easy to understand in the end I'll probably end up targeting it at your branch. |
Member
Author
|
yeah, I think the logic of your current PR is easier to understand. this adds quite some more complexity with the AttributeController. let's have the other one reviewed & merged first, it'll be easier to understand IMO. |
Open
nilsnolde
requested review from
SiarheiFedartsou,
chrstnbwnkl and
kevinkreiser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #5663
so far the new MVT endpoint is mostly good for debugging, we send all kinds of attributes, the vast majority hardly relevant for most people, and thus bloating tile size for little benefit.
this PR adds support for:
filters(same as for e.g./trace_attributes), by default we'll only return styling-relevant attributes (i.e.tile_level,road_classmostly)verbose=trueas a shortcut to manuallyincludeing all relevant debugging attributes via the filter