✨ feat(package): validate extras against package metadata#3696
Merged
Conversation
Tox silently ignored invalid extras names, leading to missing dependencies with no error. When a user configures extras that don't exist in the package (e.g. a typo), the dependency filtering finds nothing and the environment appears to work — but required packages are missing, causing confusing test failures. Validation now happens at dependency resolution time using the metadata already available at each code path: static PEP-621 optional-dependencies keys, built distribution Provides-Extra headers, and wheel/sdist metadata. Invalid extras raise a Fail with a message listing the unknown and available extras.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tox silently ignored invalid extras names, leading to missing dependencies with no error. When a user configures
extras = typo-extrabut the package only providestesting,docs,format, the dependency filtering finds nothing and the environment appears to work — but required packages are missing, causing confusing test failures that waste debugging time.Validation now happens at dependency resolution time using the metadata already available at each code path: static PEP-621
optional-dependencieskeys, built distributionProvides-Extraheaders, and wheel/sdist metadata. Invalid extras raise aFailwith a clear message listing both the unknown and available extras, e.g.extras not found for package demo: typo (available: alpha, beta).Closes #1113