Skip to content

feat: broadcast message to all workers #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
Akryum wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat: broadcast message to all workers #47

Akryum wants to merge 2 commits into from

Conversation

@Akryum
Copy link

@Akryum Akryum commented Feb 17, 2023 •
edited
Loading

related to #25

@Akryum
Copy link
Author

Akryum commented Feb 17, 2023

histoire-dev/histoire@0cbf351

Aslemammad
Aslemammad reviewed Feb 17, 2023
View reviewed changes
Copy link
Member

@Aslemammad Aslemammad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We just need a test case and a small documentation.

By the way, what if instead of broadcastMessage, we do pool.runInAll or something like that.

@Aslemammad
Copy link
Member

Aslemammad commented Mar 7, 2023

@Akryum Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Aslemammad Aslemammad Aslemammad left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Akryum @Aslemammad