Export EscapeError from the crate#584
Merged
Merged
Conversation
Mingun
approved these changes
Mar 31, 2023
Mingun
left a comment
Mingun
left a comment
Collaborator
There was a problem hiding this comment.
Please add a changelog entry
Aaron1011
force-pushed
the
export-escape-error
branch
2 times, most recently
from
eadbc41 to
aa33bb0
Compare
Contributor
Author
|
@Mingun: I've updated the changelog |
Mingun
reviewed
Apr 1, 2023
| ### Misc Changes | ||
|
|
||
| - [#579]: `ElementWriter.write_inner_content` now uses a `FnOnce` instead of a more restrictive `Fn` closure | ||
| - [#584]: Export EscapeError from the crate |
Collaborator
There was a problem hiding this comment.
You should put changelog under Unreleased section instead of modifying existing release. Also add a backticks around the type:
Suggested change
| - [#584]: Export EscapeError from the crate | |
| - [#584]: Export `EscapeError` from the crate |
This is useful when manually calling `unscape`
Mingun
force-pushed
the
export-escape-error
branch
from
aa33bb0 to
67e8f1a
Compare
crapStone
added a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Apr 18, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [quick-xml](https://github.com/tafia/quick-xml) | dependencies | patch | `0.28.1` -> `0.28.2` | --- ### Release Notes <details> <summary>tafia/quick-xml</summary> ### [`v0.28.2`](https://github.com/tafia/quick-xml/blob/HEAD/Changelog.md#​0282----2023-04-12) [Compare Source](tafia/quick-xml@v0.28.1...v0.28.2) ##### New Features - [#​581]: Allow `Deserializer` to set `quick_xml::de::EntityResolver` for resolving unknown entities that would otherwise cause the parser to return an \[`EscapeError::UnrecognizedSymbol`] error. ##### Misc Changes - [#​584]: Export `EscapeError` from the crate - [#​581]: Relax requirements for `unsescape_*` set of functions -- their now use `FnMut` instead of `Fn` for `resolve_entity` parameters, like `Iterator::map` from `std`. [#​581]: tafia/quick-xml#581 [#​584]: tafia/quick-xml#584 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS40MS4wIiwidXBkYXRlZEluVmVyIjoiMzUuNDEuMCJ9--> Co-authored-by: cabr2-bot <[email protected]> Co-authored-by: crapStone <[email protected]> Co-authored-by: crapStone <[email protected]> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1862 Reviewed-by: crapStone <[email protected]> Co-authored-by: Calciumdibromid Bot <[email protected]> Co-committed-by: Calciumdibromid Bot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful when manually calling
unscape