repart: Use new mkfs.xfs support for populating from directories #40220
+13
−187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xfsprogs 6.17.0 added support for populating xfs filesystems from directories. As this supports extended attributes unlike our current hack with protofiles. Let's make use of the new feature in mkfs-util.c As there's no clean way to do feature detection on the mkfs.xfs binary, we drop support for the old hack with protofiles that we had before.
github-actions
bot
added
documentation
util-lib
repart
please-review
yuwata
reviewed
Jan 1, 2026
Member
yuwata
left a comment
yuwata
left a comment
There was a problem hiding this comment.
Is it not possible to fallback the old way when the new method fails?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xfsprogs 6.17.0 added support for populating xfs filesystems from directories. As this supports extended attributes unlike our current hack with protofiles. Let's make use of the new feature in mkfs-util.c
As there's no clean way to do feature detection on the mkfs.xfs binary, we drop support for the old hack with protofiles that we had before.