Round BfRt meter values on read to 3 digits and multiples of 2.5 #809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pudelkoM
changed the title
Member
Author
pudelkoM
force-pushed
the
bfrt-round-meters
branch
2 times, most recently
from
c6cc119 to
3853daf
Compare
pudelkoM
force-pushed
the
bfrt-round-meters
branch
from
3853daf to
c960805
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experiment to explore if we can normalize the SDE-internal rounding to make life easier for clients. This change ensures returned values are always multiples of 2.5 with 3 significant digits. If a client programs only those, R/W symmetry is preserved.
Examples of valid values that remain the same over write -> read:
125
4875
1075000
Invalid values that will be adjusted on read:
1300 -> 1250
1010000 -> 1025000