Fix serializing JobParameter with Jackson 2 #5193
Open
+97
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quaff
force-pushed
the
patch-46
branch
2 times, most recently
from
2a5646a to
0bb92d5
Compare
Closes spring-projectsGH-5191 Signed-off-by: Yanming Zhou <[email protected]>
andrianov17
reviewed
Jan 2, 2026
| this.jsonMapper = JsonMapper.builder().activateDefaultTyping(polymorphicTypeValidator).build(); | ||
| this.jsonMapper = JsonMapper.builder() | ||
| .activateDefaultTyping(polymorphicTypeValidator) | ||
| .addMixIns(Map.of(JobParameters.class, JobParametersMixIn.class)) |
There was a problem hiding this comment.
As long as now JobParametersMixIn is added, I would recommend adjusting also constructor taking JsonMapper:
- Replace JsonMapper parameter with JsonMapper.Builder
- Add the same builder.addMixIns(Map.of(JobParameters.class, JobParametersMixIn.class))
This way, client would configure JsonMapper via JsonMapper.Builder, pass it to JacksonExecutionContextStringSerializer(JsonMapper.Builder jsonMapperBuilder) and then the mixing would be added for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes GH-5191