Replace custom converters with DefaultFormattingConversionService
#5186
+265
−134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
scordio
force-pushed
the
gh-5178-DefaultFormattingConversionService
branch
from
b8a8484 to
4aa4807
Compare
scordio
commented
Dec 29, 2025
Comment on lines
+30
to
+32
| * @deprecated since 6.1 in favor of | ||
| * {@link ConversionServiceFactory#createConversionService()}. Scheduled for removal in | ||
| * 6.3 or later. |
Contributor
Author
There was a problem hiding this comment.
Since all existing converters are public, I proposed deprecating them for removal in 6.3. Let me know if I should make any adjustments to it.
Signed-off-by: Stefano Cordio <[email protected]>
scordio
force-pushed
the
gh-5178-DefaultFormattingConversionService
branch
from
4aa4807 to
4725c88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change replaces almost all existing custom converters with the Spring Framework's
DefaultFormattingConversionServicebuilt-in features. TheDateconverters have been replaced with a custom formatter because the existing Spring Batch logic is incompatible with what the framework can offer.DefaultFormattingConversionServicealso supportsZonedDateTimeandOffsetDateTimeout of the box; therefore, this PR also resolves #5178 and is an alternative to #5179.