Conversation
|
Since there are so many violations, we would need a PR ready that fixes the violations in the main codebase before merging this one. Alternatively, something we often do is add rules as warnings, then promote them to errors once every instance is fixed. However in reality often they stay warnings forever, so if possible there can be value in fixing violations in one swoop. But warnings are still better than no warnings :) |
Yeah, I agree that if we introduce them as warnings it'll take a long time. I'll just try to fix them and test very page where I can 👍 |
|
🎉 This PR is included in version 0.23.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
4 participants
Description
Adds ESLint accessibility plugin so it's easy to do the right thing.
@quinnkeast @felixfbecker do we keep recommended rules? We need to be careful introducing this, all of the default rules are
errorand may block CI/CD.Right now our codebase has ~111 a11y errors (
yarn all:eslint | grep jsx-a11y | wc -l).Edit:
It's pretty cool we're running this config against the codebase in CI 👍 ❤️