Upgrade GitHub Actions for Node 24 compatibility#42979
Upgrade GitHub Actions for Node 24 compatibility#42979salmanmkc wants to merge 1 commit intoservo:mainfrom
Conversation
Signed-off-by: Salman Muin Kayser Chishti <[email protected]>
servo-highfive
added
the
S-awaiting-review
|
@salmanmkc Was this change or the PR description made with a large language model? |
|
I think this needs servo/ci-runners#115 before landing. |
|
please read our AI contributions policy before contributing. |
We will need this for stuff like servo/servo#42979 (I want nonzipped artifacts). Signed-off-by: Sam <[email protected]>
|
In-fact the PR you approved & merged in to upgrade the runner to 2.332.0 was the release I did last week actions/runner#4264 |
The question from @mrobinson was:
And that is a legitimate question because the PR description has telling signs of a LLM output. Maybe it's just copy/paste you use in various projects? The security note is suspicious since it talks about pinned commits that are kept as such but there are no pinned commits in Servo CI if I understand the PR itself, only version updates. |
I template my PRs to have that note about pinned versions. I wasn't talking about the question, I was responding to the fact that it was closed before I even answered the question and was told to read the AI contributions policy. What's telling of AI? |
the description reads to me like LLM output, especially these parts. it's unusually verbose and full of headings, it restates things that are clear from the changes (like the "Files" column), the "why this matters" list has three disparate facts that do not make sense to be formatted as a list, i could go on. but i can see how a human might write this, especially if you wanted something detailed enough to paste into patches to many projects without requiring too many questions from maintainers. i'll leave it to other maintainers to decide whether to reopen. |
|
Ok no worries at all, the warnings for node 20 are already showing up in all workflows, so whenever you feel like that should be addressed, then this PR is ready. |
6 participants
Summary
Upgrade GitHub Actions to their latest versions to ensure compatibility with Node 24, as Node 20 will reach end-of-life in April 2026.
Changes
actions/checkoutv5v6actions/download-artifactv4,v7v8actions/github-scriptv7v8actions/setup-javav4v5actions/setup-nodev4v6actions/upload-artifactv6v7Context
Per GitHub's announcement, Node 20 is being deprecated and runners will begin using Node 24 by default starting June 2nd, 2026.
Why this matters
always-authwas removed — if your workflow uses it, the step may failSecurity Note
Actions that were previously pinned to commit SHAs remain pinned to SHAs (updated to the latest release SHA) to maintain the security benefits of immutable references.
Testing
These changes only affect CI/CD workflow configurations and should not impact application functionality. The workflows should be tested by running them on a branch before merging.