Skip to content

Conversation

@sabinevidal
Copy link

@sabinevidal sabinevidal commented Mar 19, 2025

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Description of Changes

Updates Query generation for Snowflake to use DESCRIBE TABLE as SHOW FULL COLUMNS FROM is unsupported by Snowflake. Also updates the result parsing logic to align with the column names and formats returned by Snowflake.

Closes #15525

Improvements to Snowflake query generation:

Enhancements to query result parsing:

  • packages/snowflake/src/query.js: Updated the result parsing logic in the SnowflakeQuery class to align with the new column names and formats returned by Snowflake, ensuring accurate mapping of field properties.

List of Breaking Changes

Updated describeTableQuery as `SHOW FULL COLUMNS FROM` is not supported by Snowflake. 

Related to this issue sequelize#15525
Updated mapping to be in line with changes made to `describeTableQuery`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue in sync({alter: true}) with snowflake dialect

1 participant