fix(commonjs): preserve the class body property keys even if they are special keywords#1688
Merged
Conversation
… special keywords
lukastaegert
reviewed
Mar 5, 2024
lukastaegert
approved these changes
Mar 6, 2024
lukastaegert
left a comment
lukastaegert
left a comment
Member
There was a problem hiding this comment.
Looks good to me, thanks a lot for fixing!
|
@shellscape @lukastaegert @TrickyPi Hello, when to merge this? This issue prevent us from building Discord bot. |
younggglcy
pushed a commit
to younggglcy/plugins
that referenced
this pull request
Jun 6, 2024
… special keywords (rollup#1688)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
commonjsThis PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
resolves #1682
Description