Skip to content

Conversation

@hyf0
Copy link
Member

@hyf0 hyf0 commented Oct 3, 2025

image
  • Organize the content in reasonable scope
  • This also gives better experiences when reviewing the snapshot in some markdown friendly ide. Especially when you are checking the differences between different config variants.

Copy link
Member Author

hyf0 commented Oct 3, 2025


How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2025

Benchmarks Rust

  • target: 10-03-chore_rust_test_introduce_snapshotsection_to_organize_snapshot_content(86c7aa6)
  • pr: 10-03-chore_rust_test_sensible_heading_level_for_build_snapshot_of_config_variant(a942dec)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.03     72.9±2.15ms        ? ?/sec    1.00     70.5±1.50ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.02     80.4±2.08ms        ? ?/sec    1.00     78.5±3.18ms        ? ?/sec
bundle/bundle@rome_ts                                        1.02    116.1±2.43ms        ? ?/sec    1.00    114.1±1.84ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.01    132.6±1.90ms        ? ?/sec    1.00    131.0±2.56ms        ? ?/sec
bundle/bundle@threejs                                        1.00     45.3±0.63ms        ? ?/sec    1.01     45.6±2.51ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.01     52.5±1.72ms        ? ?/sec    1.00     51.8±1.00ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    444.3±4.04ms        ? ?/sec    1.00    442.7±4.92ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.02    518.0±7.68ms        ? ?/sec    1.00    508.5±4.15ms        ? ?/sec
scan/scan@rome_ts                                            1.00     88.9±1.64ms        ? ?/sec    1.00     89.0±1.56ms        ? ?/sec
scan/scan@threejs                                            1.00     33.5±2.00ms        ? ?/sec    1.00     33.6±2.08ms        ? ?/sec
scan/scan@threejs10x                                         1.01    341.2±5.78ms        ? ?/sec    1.00    338.7±4.46ms        ? ?/sec

@hyf0 hyf0 force-pushed the 10-03-chore_rust_test_sensible_heading_level_for_build_snapshot_of_config_variant branch from 7ee9fc2 to f707ea1 Compare October 4, 2025 07:05
@hyf0 hyf0 force-pushed the 10-03-chore_rust_test_introduce_snapshotsection_to_organize_snapshot_content branch from d87fff6 to d241c20 Compare October 4, 2025 11:21
@hyf0 hyf0 force-pushed the 10-03-chore_rust_test_sensible_heading_level_for_build_snapshot_of_config_variant branch from f707ea1 to 8d26578 Compare October 4, 2025 11:21
@hyf0 hyf0 requested a review from Boshen October 4, 2025 11:26
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 4, 2025

Merge activity

@hyf0 hyf0 force-pushed the 10-03-chore_rust_test_sensible_heading_level_for_build_snapshot_of_config_variant branch from 8d26578 to 408885d Compare October 4, 2025 13:56
@hyf0 hyf0 force-pushed the 10-03-chore_rust_test_introduce_snapshotsection_to_organize_snapshot_content branch from d241c20 to 7090564 Compare October 4, 2025 13:56
… variant (#6408)

<img width="1254" height="728" alt="image" src="https://github.com/user-attachments/assets/184b71c2-1489-4f87-8986-20e962078fe6" />

- Organize the content in reasonable scope
- This also gives better experiences when reviewing the snapshot in some markdown friendly ide. Especially when you are checking the differences between different config variants.
@graphite-app graphite-app bot force-pushed the 10-03-chore_rust_test_introduce_snapshotsection_to_organize_snapshot_content branch from 7090564 to 86c7aa6 Compare October 4, 2025 14:10
@graphite-app graphite-app bot force-pushed the 10-03-chore_rust_test_sensible_heading_level_for_build_snapshot_of_config_variant branch from 408885d to a942dec Compare October 4, 2025 14:10
Base automatically changed from 10-03-chore_rust_test_introduce_snapshotsection_to_organize_snapshot_content to main October 4, 2025 14:23
@graphite-app graphite-app bot merged commit a942dec into main Oct 4, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 10-03-chore_rust_test_sensible_heading_level_for_build_snapshot_of_config_variant branch October 4, 2025 14:24
@github-actions github-actions bot mentioned this pull request Oct 7, 2025
shulaoda pushed a commit that referenced this pull request Oct 7, 2025
## [1.0.0-beta.42] - 2025-10-07

### 🚀 Features

- rolldown: oxc v0.94.0 (#6428) by @Boshen
- add CLI environment flag (#6426) by @IWANABETHATGUY
- dev: use `RebuildStrategy#Auto` by default (#6420) by @hyf0
- rolldown_plugin_vite_html: introduce html plugin state (#6413) by @shulaoda
- dev: expose build errors via `DevOptions#on_output` (#6412) by @hyf0
- dev: add binding for `DevOptions#rebuild_strategy` (#6396) by @hyf0
- dev: add `RebuildStrategy::Auto` to issue rebuild automatically if detecting full reload hmr update (#6395) by @hyf0
- debug: inject `call_id` for `renderChunk` hook (#6392) by @hyf0
- node/dev: add `DevEngine#close` (#6377) by @hyf0
- rust/dev: add `DevEngine#close` (#6376) by @hyf0

### 🐛 Bug Fixes

- rolldown_plugin_react_refresh_wrapper: register exports in next microtask (#6423) by @sapphi-red
- plugin/vite-resolve: try original extension before replacing with TS variants (#6421) by @sapphi-red
- node/resolve: take custom package json path into account (#6419) by @hyf0
- dev: call `watchChange` hook (#6403) by @sapphi-red
- use minify options for DCE for dce-only minify (#6402) by @sapphi-red
- respect package.json type field in plugin-resolved modules (#6400) by @hyf0
- returning result of this.resolve in resolveDynamicImport hook impacts bundle size (#6397) by @sapphi-red
- rolldown_plugin_json: avoid generating named exports for `eval` and `arguments` (#6381) by @sapphi-red
- use static property for namespace object (#6383) by @sapphi-red

### 🚜 Refactor

- rust: improve constuction of `PackageJson` and remove unused fields (#6418) by @hyf0
- introduce `BindingResult` to pass errors from rust to js (#6390) by @hyf0
- rust: rename eager_rebuild to rebuild_strategy with enum (#6394) by @hyf0
- rust/binding: use `BindingError` to cover `JsError` and `NativeError` (#6388) by @hyf0
- rust/binding: rename `BindingError` to `NativeError` (#6387) by @hyf0

### 📚 Documentation

- tweak built-in transforms section (#6384) by @sapphi-red

### ⚡ Performance

- dev: avoid frequent `setTimeout` -> `clearTimeout` (#6375) by @sapphi-red

### 🧪 Testing

- hmr: include generated bundle for full reloads in snapshots (#6374) by @sapphi-red
- dev: add test about doing hmr with not being affected by not executed modules (#6360) by @hyf0
- hmr: hmr patch file generation for `this.addWatchFile` (#5219) by @sapphi-red

### ⚙️ Miscellaneous Tasks

- deps: update crate-ci/typos action to v1.38.0 (#6431) by @renovate[bot]
- deps: update crate-ci/typos action to v1.37.3 (#6429) by @renovate[bot]
- deps: lock file maintenance npm packages (#6417) by @renovate[bot]
- deps: update github-actions (#6414) by @renovate[bot]
- rust/test: sensible heading level for build snapshot of config variant (#6408) by @hyf0
- rust/test: introduce `SnapshotSection` to organize snapshot content (#6407) by @hyf0
- rust/test: extract `ArtifactsSnapshot` and `BuildRoundOutput` into standalone files (#6406) by @hyf0
- rust/test: introduce `ArtifactsSnapshot` to make generating snapshot more clear (#6405) by @hyf0
- deps: update crate-ci/typos action to v1.37.2 (#6409) by @renovate[bot]
- fix `GitHub` casing (#6401) by @iiio2
- rust: remove unused `rolldown_binding_watcher` crate (#6386) by @hyf0
- deps: update crate-ci/typos action to v1.37.1 (#6391) by @renovate[bot]
- node: rename `normalizeErrors` into `aggregateBindingErrorsIntoError` (#6389) by @hyf0
- fix typos (#6382) by @sapphi-red
- deps: update dependency tsdown to v0.15.6 (#6379) by @renovate[bot]
- deps: update crate-ci/typos action to v1.37.0 (#6380) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.16.11 (#6378) by @renovate[bot]
- add comment to `add_watch_file` that the path should be a normalized absolute path (#6371) by @sapphi-red
- deps: update dependency rolldown-plugin-dts to v0.16.10 (#6373) by @renovate[bot]

Co-authored-by: sapphi-red <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants