fix: take `resolve.modules` into account #6484

Pickachu · 2025-10-11T14:30:31Z

Summary

When resolve.modules is configured via the JavaScript API, it never reaches the native resolver. This causes module resolution to fall back to the default ["node_modules"] path set inside oxc-resolver, even when custom module directories are explicitly specified.

Root Cause

The BindingResolveOptions struct in crates/rolldown_binding/src/options/binding_input_options/binding_resolve_options.rs includes a modules field but fails to forward it in the From<BindingResolveOptions> for rolldown::ResolveOptions implementation. All other resolve options (alias, alias_fields, condition_names, etc.) are properly forwarded—modules was simply omitted.

Changes

Added the missing modules field assignment in the conversion:

impl From<BindingResolveOptions> for rolldown::ResolveOptions {
  fn from(value: BindingResolveOptions) -> Self {
    Self {
      // ... other fields
      modules: value.modules,  // ← Added
      // ... remaining fields
    }
  }
}

Questions

Was the omission of modules intentional? If so, what was the reasoning?
I believe this is the only place that needs to change to fix the issue, but I'm not 100% certain—could there be other spots in the binding layer that need updating?

Reference

Rolldown Module Resolution Documentation

graphite-app · 2025-10-11T14:30:37Z

How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

crates/rolldown_common/src/inner_bundler_options/types/resolve_options.rs

packages/rolldown/tests/fixtures/resolve/custom-modules/_config.ts

socket-security · 2025-10-12T14:20:49Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	styled-components@6.1.19

View full report

hyf0

Good work. Thank you!

@IWANABETHATGUY

## [1.0.0-beta.43] - 2025-10-13 ### 🚀 Features - add filterVitePlugins utility that uses to skip vite plugins using apply: "serve" (#6502) by @IWANABETHATGUY - rolldown_plugin_vite_html: align partial can inline entry logic (#6500) by @shulaoda - rolldown_plugin_vite_html: align get_imported_chunks logic (#6499) by @shulaoda - rolldown_plugin_vite_html: align HtmlTagDescriptor (#6498) by @shulaoda - rolldown_plugin_vite_html: align partial utility functions logic (#6497) by @shulaoda - rolldown_html_vite_html: align partial inject chunk asset links logic (#6496) by @shulaoda - rolldown_plugin_vite_html: align `processedHtml` logic (#6494) by @shulaoda - add `nativeMagicString` options (#6469) by @IWANABETHATGUY - rust: eagerly cleanup resources when calling `close` (#6483) by @hyf0 - rust: varify if bundler is closed for public API (#6481) by @hyf0 - replace [format] placeholder in chunk filename templates (#6476) by @elecmonkey - implement synchronous JS callback invocation for paths function (#6474) by @IWANABETHATGUY - rolldown_plugin_vite_html: align partial transform hook logic (#6471) by @shulaoda - Support `output.paths` (#6470) by @IWANABETHATGUY - rolldown_plugin_vite_html: align script urls handle logic (#6466) by @shulaoda - add validation for `preserveEntrySignatures` with `includeDependenciesRecursively` option (#6468) by @hyf0 - rolldown_plugin_vite_html: align partial logic (#6465) by @shulaoda - background sourcemap generation for Javascript transform hooks (#6293) by @IWANABETHATGUY - rolldown_plugin_vite_html: handle style tag (#6464) by @shulaoda - rolldown_plugin_vite_html: handle inline style attribute (#6463) by @shulaoda - rolldown_plugin_vite_html: patially handle vite-ignore attribute (#6462) by @shulaoda - dev/node: expose errors of `on_hmr_updatrs` to node (#6454) by @hyf0 - dev/node: expose errors of `on_output` to node (#6453) by @hyf0 - dev: expose hmr errors on `on_hmr_updatrs` callback (#6443) by @hyf0 ### 🐛 Bug Fixes - fallback sourcemap generation for `experimental.nativeMagicString: false` (#6488) by @IWANABETHATGUY - take `resolve.modules` into account (#6484) by @Pickachu - rolldown: increase tokio blocking threads size for watch mode (#6467) by @Brooooooklyn - use len_utf16 in magic_string CharToByteMapper (#6461) by @IWANABETHATGUY - pass `advancedChunks#includeDependenciesRecursively` to rust (#6448) by @hyf0 - dev: should compute hmr update correctly for multiple clients (#6442) by @hyf0 - allow specifying packageJsonPath in PluginContext.load (#6439) by @sapphi-red - use transform.target as default for minify target when `minify: { compress: true }` (#6433) by @sapphi-red ### 🚜 Refactor - extract background sourcemap handling into separate methods (#6501) by @IWANABETHATGUY - rust: only expose methods of `Bundler` for public usage (#6480) by @hyf0 - dev/node: use napi object instead clss for `BindingClientHmrUpdate` (#6456) by @hyf0 - dev/node: improve `DevOnHmrUpdates` API (#6455) by @hyf0 ### 📚 Documentation - update team page and add acknowledgements page (#6495) by @hyf0 - restructure website and files (#6492) by @hyf0 - correct incorrect documentation about the config file (#6472) by @jsparkdev - options: `experimental.strictExecutionOrder` (#6450) by @hyf0 - adding `why-plugin-hook-filter` in depth (#6446) by @IWANABETHATGUY ### ⚡ Performance - rolldown: replace serde JSON string escape with simd impl (#6475) by @Brooooooklyn ### ⚙️ Miscellaneous Tasks - docs: redirect removed path to new locations for compatibility (#6493) by @hyf0 - deps: lock file maintenance npm packages (#6490) by @renovate[bot] - deps: update github-actions (major) (#6415) by @renovate[bot] - deps: update github-actions (#6489) by @renovate[bot] - rust: add comment for `DiagnosticOptions#stabilize_path` (#6447) by @hyf0 - rust: remove unused `BindingHmrOutput` (#6457) by @hyf0 - rolldown_plugin_vite_html: tweak `utils.rs` (#6460) by @shulaoda - change node version to lts (#6435) by @iiio2 - rust/test: split hmr related structs into their own files (#6445) by @hyf0 - deps: update crate-ci/typos action to v1.38.1 (#6452) by @renovate[bot] - rust/test: render hmr errors (#6444) by @hyf0 - examples: add `"type": "module"` in `package.json` (#6441) by @iiio2 ### ❤️ New Contributors * @Pickachu made their first contribution in [#6484](#6484) * @elecmonkey made their first contribution in [#6476](#6476) * @jsparkdev made their first contribution in [#6472](#6472)

Pickachu force-pushed the fix-forward-resolve-modules branch from d7f8159 to 0513221 Compare October 11, 2025 14:40

hyf0 reviewed Oct 11, 2025

View reviewed changes

crates/rolldown_common/src/inner_bundler_options/types/resolve_options.rs Show resolved Hide resolved

hyf0 self-assigned this Oct 11, 2025

Pickachu force-pushed the fix-forward-resolve-modules branch 3 times, most recently from 972e9ea to 2c8db20 Compare October 12, 2025 13:54

hyf0 reviewed Oct 12, 2025

View reviewed changes

packages/rolldown/tests/fixtures/resolve/custom-modules/_config.ts Outdated Show resolved Hide resolved

fix(binding): forward resolve.modules option, with tests

f1e960f

Pickachu force-pushed the fix-forward-resolve-modules branch from 551b015 to f1e960f Compare October 12, 2025 14:20

hyf0 approved these changes Oct 12, 2025

View reviewed changes

hyf0 changed the title ~~fix(binding_input_options): forward resolve.modules option~~ fix: take resolve.modules into account Oct 12, 2025

hyf0 merged commit c4e442e into rolldown:main Oct 12, 2025
25 checks passed

github-actions bot mentioned this pull request Oct 13, 2025

release: v1.0.0-beta.43 #6503

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: take `resolve.modules` into account #6484

fix: take `resolve.modules` into account #6484

Uh oh!

Pickachu commented Oct 11, 2025

Uh oh!

graphite-app bot commented Oct 11, 2025

Uh oh!

Uh oh!

Uh oh!

socket-security bot commented Oct 12, 2025

Uh oh!

hyf0 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix: take resolve.modules into account #6484

fix: take resolve.modules into account #6484

Uh oh!

Conversation

Pickachu commented Oct 11, 2025

Summary

Root Cause

Changes

Questions

Reference

Uh oh!

graphite-app bot commented Oct 11, 2025

How to use the Graphite Merge Queue

Uh oh!

Uh oh!

Uh oh!

socket-security bot commented Oct 12, 2025

Uh oh!

hyf0 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix: take `resolve.modules` into account #6484

fix: take `resolve.modules` into account #6484