Skip to content

Conversation

@shulaoda
Copy link
Member

@shulaoda shulaoda commented Oct 8, 2025

Separated the code in utils.rs into multiple files for better organization.

Copy link
Member Author

shulaoda commented Oct 8, 2025


How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@shulaoda shulaoda changed the title chore(rolldown_plugin_vite_html): tweak utils.rs chore(rolldown_plugin_vite_html): tweak utils.rs Oct 8, 2025
@netlify
Copy link

netlify bot commented Oct 8, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 58a77eb
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68e673c7d3570200089c4c3b

@shulaoda shulaoda marked this pull request as ready for review October 8, 2025 13:33
@shulaoda shulaoda force-pushed the 10-08-chore_rolldown_plugin_vite_html_tweak_utils.rs branch from 93f5257 to 22385d3 Compare October 8, 2025 13:34
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2025

Benchmarks Rust

  • target: main(83e5355)
  • pr: 10-08-chore_rolldown_plugin_vite_html_tweak_utils.rs(58a77eb)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.01     67.1±1.26ms        ? ?/sec    1.00     66.4±1.05ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.02     74.6±2.33ms        ? ?/sec    1.00     72.9±1.27ms        ? ?/sec
bundle/bundle@rome_ts                                        1.04    117.5±6.96ms        ? ?/sec    1.00    113.3±2.44ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    129.6±2.37ms        ? ?/sec    1.00    129.1±2.02ms        ? ?/sec
bundle/bundle@threejs                                        1.00     43.3±1.25ms        ? ?/sec    1.00     43.2±0.55ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     50.1±0.83ms        ? ?/sec    1.02     51.2±0.90ms        ? ?/sec
bundle/bundle@threejs10x                                     1.01    438.7±6.39ms        ? ?/sec    1.00    434.5±5.38ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.01    500.6±4.21ms        ? ?/sec    1.00    497.0±3.73ms        ? ?/sec
scan/scan@rome_ts                                            1.00     88.2±1.59ms        ? ?/sec    1.00     88.2±1.32ms        ? ?/sec
scan/scan@threejs                                            1.00     32.2±0.47ms        ? ?/sec    1.00     32.2±0.36ms        ? ?/sec
scan/scan@threejs10x                                         1.01    335.5±4.47ms        ? ?/sec    1.00    332.9±5.75ms        ? ?/sec

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 8, 2025

Merge activity

Separated the code in `utils.rs` into multiple files for better organization.
@graphite-app graphite-app bot force-pushed the 10-08-chore_rolldown_plugin_vite_html_tweak_utils.rs branch from 22385d3 to 58a77eb Compare October 8, 2025 14:23
@graphite-app graphite-app bot merged commit 58a77eb into main Oct 8, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 10-08-chore_rolldown_plugin_vite_html_tweak_utils.rs branch October 8, 2025 14:36
shulaoda pushed a commit that referenced this pull request Oct 13, 2025
## [1.0.0-beta.43] - 2025-10-13

### 🚀 Features

- add filterVitePlugins utility that uses to skip vite plugins using apply: "serve" (#6502) by @IWANABETHATGUY
- rolldown_plugin_vite_html: align partial can inline entry logic (#6500) by @shulaoda
- rolldown_plugin_vite_html: align get_imported_chunks logic (#6499) by @shulaoda
- rolldown_plugin_vite_html: align HtmlTagDescriptor (#6498) by @shulaoda
- rolldown_plugin_vite_html: align partial utility functions logic (#6497) by @shulaoda
- rolldown_html_vite_html: align partial inject chunk asset links logic (#6496) by @shulaoda
- rolldown_plugin_vite_html: align `processedHtml` logic (#6494) by @shulaoda
- add `nativeMagicString` options (#6469) by @IWANABETHATGUY
- rust: eagerly cleanup resources when calling `close` (#6483) by @hyf0
- rust: varify if bundler is closed for public API (#6481) by @hyf0
- replace [format] placeholder in chunk filename templates (#6476) by @elecmonkey
- implement synchronous JS callback invocation for paths function (#6474) by @IWANABETHATGUY
- rolldown_plugin_vite_html: align partial transform hook logic (#6471) by @shulaoda
- Support `output.paths` (#6470) by @IWANABETHATGUY
- rolldown_plugin_vite_html: align script urls handle logic (#6466) by @shulaoda
- add validation for `preserveEntrySignatures` with `includeDependenciesRecursively` option (#6468) by @hyf0
- rolldown_plugin_vite_html: align partial logic (#6465) by @shulaoda
- background sourcemap generation for Javascript transform hooks (#6293) by @IWANABETHATGUY
- rolldown_plugin_vite_html: handle style tag (#6464) by @shulaoda
- rolldown_plugin_vite_html: handle inline style attribute (#6463) by @shulaoda
- rolldown_plugin_vite_html: patially handle vite-ignore attribute (#6462) by @shulaoda
- dev/node: expose errors of `on_hmr_updatrs` to node (#6454) by @hyf0
- dev/node: expose errors of `on_output` to node (#6453) by @hyf0
- dev: expose hmr errors on `on_hmr_updatrs` callback (#6443) by @hyf0

### 🐛 Bug Fixes

- fallback sourcemap generation for `experimental.nativeMagicString: false` (#6488) by @IWANABETHATGUY
- take `resolve.modules` into account (#6484) by @Pickachu
- rolldown: increase tokio blocking threads size for watch mode (#6467) by @Brooooooklyn
- use len_utf16 in magic_string CharToByteMapper (#6461) by @IWANABETHATGUY
- pass `advancedChunks#includeDependenciesRecursively` to rust (#6448) by @hyf0
- dev: should compute hmr update correctly for multiple clients (#6442) by @hyf0
- allow specifying packageJsonPath in PluginContext.load (#6439) by @sapphi-red
- use transform.target as default for minify target when `minify: { compress: true }` (#6433) by @sapphi-red

### 🚜 Refactor

- extract background sourcemap handling into separate methods (#6501) by @IWANABETHATGUY
- rust: only expose methods of `Bundler` for public usage (#6480) by @hyf0
- dev/node: use napi object instead clss for `BindingClientHmrUpdate` (#6456) by @hyf0
- dev/node: improve `DevOnHmrUpdates` API (#6455) by @hyf0

### 📚 Documentation

- update team page and add acknowledgements page (#6495) by @hyf0
- restructure website and files (#6492) by @hyf0
- correct incorrect documentation about the config file (#6472) by @jsparkdev
- options: `experimental.strictExecutionOrder` (#6450) by @hyf0
- adding `why-plugin-hook-filter` in depth (#6446) by @IWANABETHATGUY

### ⚡ Performance

- rolldown: replace serde JSON string escape with simd impl (#6475) by @Brooooooklyn

### ⚙️ Miscellaneous Tasks

- docs: redirect removed path to new locations for compatibility (#6493) by @hyf0
- deps: lock file maintenance npm packages (#6490) by @renovate[bot]
- deps: update github-actions (major) (#6415) by @renovate[bot]
- deps: update github-actions (#6489) by @renovate[bot]
- rust: add comment for `DiagnosticOptions#stabilize_path` (#6447) by @hyf0
- rust: remove unused `BindingHmrOutput` (#6457) by @hyf0
- rolldown_plugin_vite_html: tweak `utils.rs` (#6460) by @shulaoda
- change node version to lts (#6435) by @iiio2
- rust/test: split hmr related structs into their own files (#6445) by @hyf0
- deps: update crate-ci/typos action to v1.38.1 (#6452) by @renovate[bot]
- rust/test: render hmr errors (#6444) by @hyf0
- examples: add `"type": "module"` in `package.json` (#6441) by @iiio2

### ❤️ New Contributors

* @Pickachu made their first contribution in [#6484](#6484)
* @elecmonkey made their first contribution in [#6476](#6476)
* @jsparkdev made their first contribution in [#6472](#6472)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants