Skip to content

Add LightbulbStyle#2474

Merged
jeanas merged 4 commits into
pygments:masterfrom
ykrx:master
Jul 18, 2023
Merged

Add LightbulbStyle#2474
jeanas merged 4 commits into
pygments:masterfrom
ykrx:master

Conversation

@ykrx

@ykrx ykrx commented Jul 15, 2023

Copy link
Copy Markdown
Contributor

A minimal dark theme based on the Lightbulb theme for VSCode.

Screenshot 2023-07-17 at 3 00 14 AM

@Anteru

Anteru commented Jul 16, 2023

Copy link
Copy Markdown
Collaborator

Thanks for the contribution! Unfortunately, your style doesn't pass the WCAG recommendation for contrast, is there any chance you can bump the contrast? Dark theme or not, we do want to maintain some level of accessibility, and often times only small tweaks are needed to get there.

@Anteru Anteru added the A-theming area: changes to themes label Jul 16, 2023
Comment thread tests/contrast/min_contrasts.json Outdated
Comment thread tests/contrast/min_contrasts.json
Comment thread pygments/styles/lightbulb.py
Comment thread pygments/styles/lightbulb.py
@jeanas

jeanas commented Jul 18, 2023

Copy link
Copy Markdown
Contributor

Looks good, thanks:

@jeanas jeanas merged commit ab41859 into pygments:master Jul 18, 2023
@Anteru Anteru added this to the 2.16.0 milestone Jul 18, 2023
@numist

numist commented Aug 8, 2023

Copy link
Copy Markdown

This PR says merged but I don't see anything matching eclipse in the output of get_all_styles()… what is the name of this new style?

@jeanas

jeanas commented Aug 8, 2023

Copy link
Copy Markdown
Contributor

“lightbulb”

@numist

numist commented Aug 8, 2023

Copy link
Copy Markdown

Oops, I'd intended to write this in #2440, which I now see was declined.

So only one new style for 2.16.0 then?

@jeanas

jeanas commented Aug 8, 2023

Copy link
Copy Markdown
Contributor

FWIW, #2240 wasn't declined, but somehow the author decided (for reasons that are not clear to me) to close the PR and even delete the source branch.

@numist

numist commented Aug 9, 2023

Copy link
Copy Markdown

Sorry I didn't mean to imply who declined the PR, just the general term used in my parts.

Too bad; new themes are fun.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-theming area: changes to themes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants