Skip to content

Allow skipping symlink patterns, to avoid raising a fault#15533

Merged
sosukesuzuki merged 13 commits intoprettier:mainfrom
sanmai-NL:Recover-from-breaking-change-to-symlink-handling
Dec 7, 2023
Merged

Allow skipping symlink patterns, to avoid raising a fault#15533
sosukesuzuki merged 13 commits intoprettier:mainfrom
sanmai-NL:Recover-from-breaking-change-to-symlink-handling

Conversation

@sanmai-NL
Copy link
Copy Markdown
Contributor

@sanmai-NL sanmai-NL commented Oct 23, 2023

Description

In #14627, Prettier was redesigned to ‘no longer follow symbolic links’. However, the implementation went further and turned into a breaking change. Rather than adhering to the exit status contract of only returning a non-zero exit status when a file is not formatted or when something is wrong with Prettier itself, #14627 made Prettier return a non-zero exit status upon any pattern turning out to be a pointing to symlink.

This PR fixes the original PR by @andersk to behave in line with its documentation.

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants