Move the class members after the value types. #29020
Conversation
…s" or groups the JNI types.
|
Hi @Junio00r, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user Junio00r" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
|
❗ This change is not yet ready to be integrated. |
1 participant
This change "modularizes" or groups the JNI types. It seems easier to consider that all JNI types come first; this makes it easier to abstract by simply considering "all JNI types are there".
Of course, it's not much, but it seems better than having a difference to only mention the members and then going back to some types.
Progress
Error
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29020/head:pull/29020$ git checkout pull/29020Update a local copy of the PR:
$ git checkout pull/29020$ git pull https://git.openjdk.org/jdk.git pull/29020/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 29020View PR using the GUI difftool:
$ git pr show -t 29020Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29020.diff