dnn: fix blobRectsToImageRects mapping for padding modes (#26085) #28340
+74
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmorkalov
added
category: dnn
pr: needs test
Contributor
|
@dheeraj25406 Please add simple test that highlights the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #26085
The function
Image2BlobParams::blobRectsToImageRectsreturned incorrect bounding boxes when using padding modes such asDNN_PMODE_LETTERBOXandDNN_PMODE_CROP_CENTER.Root Cause
The offset introduced during preprocessing was not removed correctly when mapping blob‐space rectangles back to original image coordinates.
Fix
Adjust rectangle coordinates based on resize factor and padding offsets, so that coordinates are mapped consistently to the original image space.
Testing
opencv_test_dnn --gtest_filter=*blobRects*