feat: add Tencent GooseFS Table Master namespace implementation (Python)#122
Open
XuQianJin-Stars wants to merge 4 commits into
Open
feat: add Tencent GooseFS Table Master namespace implementation (Python)#122XuQianJin-Stars wants to merge 4 commits into
XuQianJin-Stars wants to merge 4 commits into
Conversation
# Conflicts: # python/pyproject.toml # python/uv.lock
|
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
XuQianJin-Stars
changed the title
XuQianJin-Stars
changed the title
- Add managed_versioning config flag on GooseFSNamespace. When enabled, describe_table and declare_table responses advertise managed_versioning=True so Lance routes commits through this namespace's create_table_version API via the external manifest commit handler. - Conditionally import CreateEmptyTableRequest/Response, falling back to CreateTableRequest/Response which superseded them in lance-namespace >= 0.8, keeping backward compatibility with older clients.
…d error handling - Add _raise_table_not_found to raise typed TABLE_NOT_FOUND errors for pylance - Add _lift_table_version_metadata to promote metadata fields to top-level TableVersion - Add _is_table_not_found_error heuristic for gRPC error detection - Add Lance root path support (_normalize_lance_root, _default_table_location) - Add storage_options merge (_merge_storage_options) for goosefs_auth_type propagation - Add _namespace_relative_manifest_path and _strip_table_dir_from_version to repair manifest path asymmetry between Lance table-root and GooseFS namespace-root - Add _coerce_request to handle DictWithModelDump from pylance Rust glue - Improve describe_table/declare_table with fallback location and storage_options - Improve list_table_versions/create_table_version/describe_table_version with metadata lifting and path normalization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #121
Summary
Add a new Lance Namespace implementation backed by Tencent Cloud GooseFS Table Master to the Python lance-namespace-impls package. GooseFS Table Master is a Lance-native metadata service exposed over gRPC and is purpose-built for Lance, so every registered table is a Lance table and no
table_type=lancemarker filtering is required on the client side.This implementation acts as a thin pass-through layer that translates each Lance Namespace request into the corresponding gRPC request defined by the GooseFS Table Master schema, forwarded through the official
goosefs-metastore-clientlibrary. It follows the same integration pattern already used for Hive, Glue, Iceberg, Polaris, and Unity in this repo.Changes
GooseFSNamespaceclass inpython/src/lance_namespace_impls/goosefs.py, registered asgoosefsinLanceNamespaces.uri,host,port,timeout,max_retries), authentication (authentication_enabled,username,impersonation_user), and namespace defaults (manifest_enabled,dir_listing_enabled).goosefsinpython/pyproject.tomlwithgoosefs-metastore-client==0.1.7,grpcio>=1.78,grpcio-status>=1.78.lint-goosefs,install-goosefs,test-goosefs,integ-test-goosefs.python/tests/test_goosefs.pyand integration tests inpython/tests/test_goosefs_integration.py(auto-skipped when the service is unreachable).docs/src/goosefs.mdand navigation entry indocs/src/.pages.Testing
ruff format --checkandruff checkpass on the wholepython/tree.python -m compileallsucceeds forsrc/andtests/. Unit tests pass with thegoosefsextra installed. Integration tests pass against a live GooseFS Table Master.User-facing changes
Purely additive: a new optional extra
pip install lance-namespace[goosefs], a new impl namegoosefsforLanceNamespaces.connect, and a new docs page. No existing implementation is modified.