• igraph_i_generate_subsets does not have a return type; it should be igraph_error_t and you should wrap the inner igraph_vector_list_... call in an IGRAPH_CHECK() to make sure that error codes are handled and propagated correctly. You should return IGRAPH_SUCCESS from the function when you wish to terminate the recursion.
• Global variables should not be used; igraph_i_generate_subsets() should receive the vector list in which the subsets should be filled as a parameter.
• The nCk variable is redundant; you can just return the corresponding expression directly.
• genSubset is not defined; you probably meant igraph_i_generate_subsets(), right?

• genSubset is not defined; you probably meant igraph_i_generate_subsets(), right?

Hi. You're right, my bad. I forgot to change the name while refactoring.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.51%. Comparing base (e4fd298) to head (b443766).
⚠️ Report is 3 commits behind head on main.

@@           Coverage Diff           @@
##             main    #2233   +/-   ##
=======================================
  Coverage   75.51%   75.51%           
=======================================
  Files         406      406           
  Lines       75313    75313           
  Branches    15049    15049           
=======================================
  Hits        56870    56870           
  Misses      18443    18443           

Just a note that it's strongly preferred to use non-recursive implementations. Recursive functions are prone to stack overflow. This has happened in the past.

Hi. I thought I would just give an update here. I have made igraph_i_generate_subsets iterative. I am still working on making igraph_i_number_of_subsets iterative.

Edit: Both functions are now iterative.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

What's the status of this PR? @valdaarhun are you waiting for us before you continue?

Hi. Yes, I was waiting for feedback. I apologize for not sending a reminder, I got caught up with other work. I would like to resume working on this now.

Hi. Yes, I was waiting for feedback. I apologize for not sending a reminder, I got caught up with other work. I would like to resume working on this now.

No apologies necessary 🙂
As Tamás noticed, your types are not completely correct.

If you add your file to src/CMakeLists.txt you can use CMake to build your code and see the warnings.
(You can also maybe set up your editor so you can see these warnings while coding.)

If you add the actual generator function (or maybe for now just something that tests your subset generator) you can also add some tests in /tests/unit/ and add it in tests/CMakeLists, so your code gets run. That's one basic way of getting some feedback on your code :)

If you have any further questions (like about using CMake) don't hesitate to ask.

If you add your file to src/CMakeLists.txt you can use CMake to build your code and see the warnings. (You can also maybe set up your editor so you can see these warnings while coding.)

If you add the actual generator function (or maybe for now just something that tests your subset generator) you can also add some tests in /tests/unit/ and add it in tests/CMakeLists, so your code gets run. That's one basic way of getting some feedback on your code :)

Oh, that's nice. I'll definitely do this.

If you have any further questions (like about using CMake) don't hesitate to ask.

Sure thing. Thanks.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.