[V4] models js #1494
Open
[V4] models js #1494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xenova
requested changes
Dec 23, 2025
Collaborator
There was a problem hiding this comment.
Thanks for the PR! A refactor of the monolithic models.js is desperately needed. As mentioned elsewhere, ideally, we'd align quite closely with the python library structure, meaning keeping everything under the model type:
https://github.com/huggingface/transformers/tree/main/src/transformers/models
So, for example, src/models/pre-trained-models/albert-pre-trained-model.js should be src/models/albert/modeling_albert.js
also, weirdly, the rebase doesn't seem to be applied correctly (we can see the previous commits too)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.