Context

core.alter('remove_row') doesn't correctly handle cases where the visual and physical row counts don't match (eg. the table has trimmed rows)

Row removal is eventually handled by DataMap.removeRow(index, amount, source) which uses DataMap.visualRowsToPhysical(visualRowIndex, amount) to convert the passed range of visual rows to an array of physical row indexes.

visualRowsToPhysical() attempts to:

1. Normalize the passed index and amount parameters based on the size of the table
2. iterate over each visual row within the normalized visual row index and visual row count
3. convert the visual row index to its physical equivalent
4. return array of physical row indexes

The existing logic for step 1 is incorrectly normalizing the passed arguments using the physical number of rows in the columns instead of the visual number of rows. This pull request fixes the normalization to use countRows() instead of countSourceRows(). It also renames the incorrectly named physicRow variable to visualRow since it contains the current visual row index during loop iteration.

How has this been tested?

This has been tested by using verifying the behavior demonstrated by the codesandbox provided with #11643 works as expected regardless of whether the table contains trimmed rows or not.

It is also worth nothing that the fixed normalization logic in visualRowsToPhysical() is now consistent with visualColumnsToPhysical() which provides the same functionality but for columns (although, it too suffers from an incorrectly named physicalCol variable).

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature or improvement (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Additional language file or change to the existing one (translations)

Related issue(s):

1. core.alter('remove_row') does not account for trimmed rows #11643

Affected project(s):

• handsontable
• @handsontable/angular
• @handsontable/react
• @handsontable/react-wrapper
• @handsontable/vue
• @handsontable/vue3

Checklist:

• I have reviewed the guidelines about Contributing to Handsontable and I confirm that my code follows the code style of this project.
• I have signed the Contributor License Agreement
• My change requires a change to the documentation.