Skip to content

xds: implement server feature fail_on_data_errors#12544

Merged
shivaspeaks merged 5 commits intogrpc:masterfrom
shivaspeaks:server_feature_fail_on_data_errors
Dec 5, 2025
Merged

xds: implement server feature fail_on_data_errors#12544
shivaspeaks merged 5 commits intogrpc:masterfrom
shivaspeaks:server_feature_fail_on_data_errors

Conversation

@shivaspeaks
Copy link
Copy Markdown
Member

Implements server feature fail_on_data_errors, per gRFC A88: https://github.com/grpc/proposal/blob/master/A88-xds-data-error-handling.md

@shivaspeaks shivaspeaks force-pushed the server_feature_fail_on_data_errors branch from 584e614 to 342c6e1 Compare December 2, 2025 08:47
@shivaspeaks shivaspeaks marked this pull request as ready for review December 2, 2025 09:00
Copy link
Copy Markdown
Contributor

@kannanjgithub kannanjgithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review comments.

Comment thread xds/src/main/java/io/grpc/xds/client/XdsClientImpl.java
Comment thread xds/src/main/java/io/grpc/xds/client/XdsClientImpl.java Outdated
Copy link
Copy Markdown
Contributor

@kannanjgithub kannanjgithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments on tests.

Comment thread xds/src/test/java/io/grpc/xds/GrpcXdsClientImplTestBase.java
Comment thread xds/src/test/java/io/grpc/xds/GrpcXdsClientImplTestBase.java
Comment thread xds/src/test/java/io/grpc/xds/GrpcXdsClientImplTestBase.java
@shivaspeaks shivaspeaks merged commit b1a94a4 into grpc:master Dec 5, 2025
17 checks passed
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants