Skip to content

Comments

Removed cancel operation support#3889

Merged
bbakerman merged 1 commit intomasterfrom
remove-cancel-operation
Apr 4, 2025
Merged

Removed cancel operation support#3889
bbakerman merged 1 commit intomasterfrom
remove-cancel-operation

Conversation

@bbakerman
Copy link
Member

@bbakerman bbakerman commented Apr 4, 2025

The cancel operation support is not working as expected. At this late stage in the release process we think we should remove it and then re-look at it once we have released.

This removes much of the code however leaves a bit of it around so we can more easily put it back

@bbakerman bbakerman added this to the 23.0 breaking changes milestone Apr 4, 2025
@bbakerman bbakerman mentioned this pull request Apr 4, 2025
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2025

Test Results

  313 files  ±0    313 suites  ±0   49s ⏱️ -2s
3 586 tests  - 2  3 581 ✅  - 1  5 💤 ±0  0 ❌  - 1 
3 675 runs   - 2  3 670 ✅  - 1  5 💤 ±0  0 ❌  - 1 

Results for commit 91f1967. ± Comparison against base commit 23012ad.

This pull request removes 152 and adds 128 tests. Note that renamed tests count towards both. 
	?
                __schema { types { fields { args { type { name fields { name }}}}}}
                __schema { types { fields { type { name fields { name }}}}}
                __schema { types { inputFields { type { inputFields { name }}}}}
                __schema { types { interfaces { fields { type { interfaces { name } } } } } }
                __schema { types { name} }
                __type(name : "t") { name }
                a1: __schema { types { name} }
                a1: __type(name : "t") { name }
                a2 :  __type(name : "t1") { name }
…

graphql.ScalarsBooleanTest ‑ parseValue throws exception for invalid input <java.lang.Object@4767246b>
graphql.ScalarsBooleanTest ‑ serialize throws exception for invalid input <java.lang.Object@51424223>
graphql.ScalarsIDTest ‑ parseValue allows any object via String.valueOf <java.lang.Object@20cbf686>
graphql.ScalarsIDTest ‑ serialize allows any object via String.valueOf <java.lang.Object@72d68d49>
graphql.ScalarsIntTest ‑ parseValue throws exception for invalid input <java.lang.Object@880a59c>
graphql.ScalarsIntTest ‑ serialize throws exception for invalid input <java.lang.Object@141d86b7>
graphql.execution.instrumentation.TracingInstrumentationTest ‑ do not trace introspection information [testExecutionStrategy: <graphql.execution.AsyncExecutionStrategy@637fe4da fieldCollector=graphql.execution.FieldCollector@676294f2 executionStepInfoFactory=graphql.execution.ExecutionStepInfoFactory@68d9f56e dataFetcherExceptionHandler=graphql.execution.SimpleDataFetcherExceptionHandler@750c224a resolvedType=graphql.execution.ResolveType@69494105>, #0]
graphql.execution.instrumentation.TracingInstrumentationTest ‑ do not trace introspection information [testExecutionStrategy: <graphql.execution.AsyncSerialExecutionStrategy@3d2a697e fieldCollector=graphql.execution.FieldCollector@292012e3 executionStepInfoFactory=graphql.execution.ExecutionStepInfoFactory@a422fab dataFetcherExceptionHandler=graphql.execution.SimpleDataFetcherExceptionHandler@6c357264 resolvedType=graphql.execution.ResolveType@2ba9705>, #1]
graphql.execution.instrumentation.TracingInstrumentationTest ‑ tracing captures timings as expected [testExecutionStrategy: <graphql.execution.AsyncExecutionStrategy@48be74df fieldCollector=graphql.execution.FieldCollector@53cfce86 executionStepInfoFactory=graphql.execution.ExecutionStepInfoFactory@28204f0e dataFetcherExceptionHandler=graphql.execution.SimpleDataFetcherExceptionHandler@5e5a8026 resolvedType=graphql.execution.ResolveType@65f90fbe>, #0]
graphql.execution.instrumentation.TracingInstrumentationTest ‑ tracing captures timings as expected [testExecutionStrategy: <graphql.execution.AsyncSerialExecutionStrategy@6ae1a545 fieldCollector=graphql.execution.FieldCollector@169f04dd executionStepInfoFactory=graphql.execution.ExecutionStepInfoFactory@af0efde dataFetcherExceptionHandler=graphql.execution.SimpleDataFetcherExceptionHandler@253f92f0 resolvedType=graphql.execution.ResolveType@4213c09f>, #1]
…

@bbakerman bbakerman merged commit 6eb2616 into master Apr 4, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

23.0 breaking changes

Development

Successfully merging this pull request may close these issues.

1 participant

@bbakerman