Avoid overhead of Stream / Iterator in RulesVisitor#3804
Merged
bbakerman merged 1 commit intographql-java:masterfrom Jan 28, 2025
Merged
Avoid overhead of Stream / Iterator in RulesVisitor#3804bbakerman merged 1 commit intographql-java:masterfrom
bbakerman merged 1 commit intographql-java:masterfrom
Conversation
Avoid overhead of creating a Stream in filterRulesVisitingFragmentSpreads, and instead just do the filtering inline in a for loop.
dondonz
added
the
performance
dondonz
approved these changes
Jan 28, 2025
Member
dondonz
left a comment
dondonz
left a comment
There was a problem hiding this comment.
Thanks for all these performance improvements!
bbakerman
approved these changes
Jan 28, 2025
Member
bbakerman
left a comment
bbakerman
left a comment
There was a problem hiding this comment.
Did this turn up in a profiler or just getting rid of .stream()s
Contributor
Author
Hey @bbakerman . I am not trying to get rid of all stream calls, this came up when I was profiling an instrumentation implementation. It is true though that in hot code, stream can add quite a bit of overhead. For trivial scenarios like the filtering done in this method it seems straightforward to just unroll it into a loop and avoid the cost. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid overhead of creating a Stream in filterRulesVisitingFragmentSpreads, and instead just do the filtering inline in a for loop.