Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: googleapis/google-cloud-java
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: googleapis/google-cloud-java
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: fix-issue-13364-java
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 2 files changed
  • 1 contributor

Commits on Jun 30, 2026

  1. test(pubsub): fix deadlock in PublisherImplTest and SubscriberTest 

    Use a dedicated executor for the mock gRPC server in PublisherImplTest
and SubscriberTest.

The mock servers in these tests use blocking queues (`take()`) to
coordinate with the test thread. By default, `InProcessServerBuilder`
uses a direct executor, which runs the server-side logic synchronously
on the client's thread. When the client-side call is made from the test's
main thread (e.g., during a synchronous flush when a batch threshold is
reached), the server blocks the main thread, leading to a deadlock as
the main thread cannot proceed to add the expected response.

By running the mock server on a dedicated executor, the server-side
blocking call runs on a separate thread, allowing the main test thread
to proceed and add the response, resolving the deadlock.

This allows re-enabling the previously ignored tests:
- `PublisherImplTest.testResumePublish`
- `PublisherImplTest.testPublishThrowExceptionForUnsubmittedOrderingKeyMessage`

Fixes #13364
Fixes #13394

BUG=520086541
BUG=521517197
TAG=agy
CONV=5eedeefa-4e53-4b06-a6da-9dbd08cc0162
    @lqiu96
    lqiu96 committed Jun 30, 2026
    Configuration menu
    Copy the full SHA
    d3ce9cc View commit details
    Browse the repository at this point in the history
Loading