fix(browser/v7): Don't assume window.document is available#11598
Merged
Conversation
Contributor
size-limit report 📦
|
lforst
changed the title
added 2 commits
April 15, 2024 12:12
|
I'm wondering if it's feasible to drop the DOM-lib in this project's tsconfig, to prevent accidental breakage for WebWorkers? And a small review nudge: I personally really like optional chaining to turn if (WINDOW.document) WINDOW.document.addEventListener(...)into WINDOW.document?.addEventListener(...)(Might not apply here due to code style or something. Putting it out here just in case) |
Lms24
approved these changes
Apr 15, 2024
Comment on lines
+13
to
14
| if (WINDOW.document) { | ||
| WINDOW.document.addEventListener('visibilitychange', () => { |
Member
There was a problem hiding this comment.
l/feel free to ignore: This should be safe here, right?
Suggested change
| if (WINDOW.document) { | |
| WINDOW.document.addEventListener('visibilitychange', () => { | |
| if (WINDOW.document) { | |
| addEventListener('visibilitychange', () => { |
| if (isPageloadTransaction && WINDOW.document) { | ||
| WINDOW.document.addEventListener('readystatechange', () => { | ||
| if (['interactive', 'complete'].includes(WINDOW.document.readyState)) { | ||
| if (['interactive', 'complete'].includes(WINDOW.document!.readyState)) { |
Member
There was a problem hiding this comment.
l: does TS not infer the definedness of WINDOW.document from above? maybe not because of the callback?
Contributor
Optional chaining transpiles into larger bundle size than we want if you don't target es2020 (which we don't atm). |
Closed
This was referenced Jun 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #5289 (comment)
We technically support webworkers so we cannot assume that document API is available.