feat: fetch all Azure KV secret and certificates in separate ClusterExternalSecret #5691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
kind/feature
|
gusfcarvalho
reviewed
Dec 8, 2025
| "encoding/json" | ||
|
|
||
| esv1 "github.com/external-secrets/external-secrets/apis/externalsecrets/v1" | ||
| esv1beta1 "github.com/external-secrets/external-secrets/apis/externalsecrets/v1beta1" |
gusfcarvalho
reviewed
Dec 8, 2025
Comment on lines
+300
to
+355
|
|
||
| // Certificates | ||
| certsPager := a.certsClient.NewListCertificatePropertiesPager(nil) | ||
| for certsPager.More() { | ||
| page, err := certsPager.NextPage(ctx) | ||
| metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVGetCertificate, err) | ||
| if err != nil { | ||
| return nil, parseNewSDKError(err) | ||
| } | ||
|
|
||
| for _, cert := range page.Value { | ||
| if cert == nil || cert.ID == nil { | ||
| continue | ||
| } | ||
|
|
||
| name := cert.ID.Name() | ||
|
|
||
| resp, err := a.certsClient.GetCertificate(ctx, name, "", nil) | ||
| if err != nil { | ||
| return nil, parseNewSDKError(err) | ||
| } | ||
|
|
||
| if resp.CER != nil { | ||
| secretsMap["cert/"+name] = resp.CER | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // Keys | ||
| keysPager := a.keysClient.NewListKeyPropertiesPager(nil) | ||
| for keysPager.More() { | ||
| page, err := keysPager.NextPage(ctx) | ||
| metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVGetKey, err) | ||
| if err != nil { | ||
| return nil, parseNewSDKError(err) | ||
| } | ||
|
|
||
| for _, keyProps := range page.Value { | ||
| if keyProps == nil || keyProps.KID == nil { | ||
| continue | ||
| } | ||
|
|
||
| name := keyProps.KID.Name() | ||
|
|
||
| resp, err := a.keysClient.GetKey(ctx, name, "", nil) | ||
| if err != nil { | ||
| return nil, parseNewSDKError(err) | ||
| } | ||
|
|
||
| if resp.Key != nil { | ||
| jwkBytes, _ := json.Marshal(resp.Key) | ||
| secretsMap["key/"+name] = jwkBytes | ||
| } | ||
| } | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
current users will have a breaking change if exposed to this logic. We are failing if there are no valid permissions for certificates and keys -- instead we should log the error and continue to avoid breaking changes for setup that did not give cert/key permissions to external-secrets.
gusfcarvalho
reviewed
Dec 8, 2025
|
|
||
| if resp.Key != nil { | ||
| jwkBytes, _ := json.Marshal(resp.Key) | ||
| secretsMap["key/"+name] = jwkBytes |
Member
There was a problem hiding this comment.
Are we sure we want to leave this key in a format that is incompatible with Kubernetes Secret regex?
It means a dataFrom.find targeting key vault will always fail unless the user manipulates the keys.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
When using dataFrom.find.path in Azure Key Vault, using path "cert/" obtains both certificates and secrets. We want to sepaate the fetching by specific prefixes.
Related Issue
Fixes #4541
Proposed Changes
This update enhances the Azure provider by adding end-to-end support for secrets, certificates, and keys when using the new SDK. The function now iterates through the SDK pagers, fetches certificate/key data, JSON-encodes JWKs, and returns a unified map.
Format
Please ensure that your PR follows the following format for the title:
Where
scopeis optionally one of:Checklist
git commit --signoffmake testmake reviewable